From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6EC2BC433F5
	for <linux-kernel@archiver.kernel.org>; Tue,  1 Feb 2022 07:12:11 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234591AbiBAHMK (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 1 Feb 2022 02:12:10 -0500
Received: from smtp-out1.suse.de ([195.135.220.28]:60416 "EHLO
        smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230420AbiBAHMJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Feb 2022 02:12:09 -0500
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out1.suse.de (Postfix) with ESMTP id 98B4C21123;
        Tue,  1 Feb 2022 07:12:08 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1643699528; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=e5pD/uyOwT+fedUBHy30mmqQQ/tiB8vLKqaMblLPE4c=;
        b=LJZAXPRKUz7u/m1675ly31YhkgZUyGmM++COT5l+I3BYdijN0y9CFdzvW81HaQibiKAKNs
        tzvMthLe/OJRxWwmsr8QOg4aNgd4lJAu8PPwkHYG54Fo7jHaUkzwxOjDH0pFqk8APO4W7z
        hiiXZq6WITtRCrcZ2U32etwl2SxlYpE=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1643699528;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=e5pD/uyOwT+fedUBHy30mmqQQ/tiB8vLKqaMblLPE4c=;
        b=pRjGTbt27b62yWSDQPxoQJlHNAHrM7cbpA+qM2kJYNix6Kmi3QYHSRjtfBlqUu6LuS5yEi
        Bom8ceSSw/AA6rDQ==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 8BD9FA3B84;
        Tue,  1 Feb 2022 07:12:08 +0000 (UTC)
Date:   Tue, 01 Feb 2022 08:12:08 +0100
Message-ID: <s5hy22v83hz.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jonas Hahnfeld <hahnjo@hahnjo.de>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Jukka Heikintalo <heikintalo.jukka@gmail.com>,
        =?UTF-8?B?UGF3ZcWC?= Susicki <pawel.susicki@gmail.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Correct quirk for VF0770
In-Reply-To: <20220131183516.61191-1-hahnjo@hahnjo.de>
References: <20220131183516.61191-1-hahnjo@hahnjo.de>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 31 Jan 2022 19:35:16 +0100,
Jonas Hahnfeld wrote:
> 
> This device provides both audio and video. The original quirk added in
> commit 48827e1d6af5 ("ALSA: usb-audio: Add quirk for VF0770") used
> USB_DEVICE to match the vendor and product ID. Depending on module order,
> if snd-usb-audio was asked first, it would match the entire device and
> uvcvideo wouldn't get to see it. Change the matching to USB_AUDIO_DEVICE
> to restore uvcvideo matching in all cases.
> 
> Fixes: 48827e1d6af5 ("ALSA: usb-audio: Add quirk for VF0770")
> Reported-by: Jukka Heikintalo <heikintalo.jukka@gmail.com>
> Tested-by: Jukka Heikintalo <heikintalo.jukka@gmail.com>
> Reported-by: Paweł Susicki <pawel.susicki@gmail.com>
> Tested-by: Paweł Susicki <pawel.susicki@gmail.com>
> Cc: <stable@vger.kernel.org> # 5.4, 5.10, 5.14, 5.15
> Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>

Thanks, applied now.


Takashi