From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D66C00449 for ; Wed, 3 Oct 2018 18:34:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67988206B2 for ; Wed, 3 Oct 2018 18:34:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67988206B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbeJDBYY (ORCPT ); Wed, 3 Oct 2018 21:24:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:44750 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726884AbeJDBYY (ORCPT ); Wed, 3 Oct 2018 21:24:24 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 98780ACDE; Wed, 3 Oct 2018 18:34:49 +0000 (UTC) Date: Wed, 03 Oct 2018 20:34:49 +0200 Message-ID: From: Takashi Iwai To: "Gustavo A. R. Silva" Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: intel8x0: Fix fall-through annotations In-Reply-To: <787e9aeb-34e0-3075-d816-7963cca61020@embeddedor.com> References: <20181003103836.GA21649@embeddedor.com> <787e9aeb-34e0-3075-d816-7963cca61020@embeddedor.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 03 Oct 2018 20:08:31 +0200, Gustavo A. R. Silva wrote: > > > > On 10/3/18 6:19 PM, Takashi Iwai wrote: > > On Wed, 03 Oct 2018 18:08:07 +0200, > > Takashi Iwai wrote: > >> > >> On Wed, 03 Oct 2018 12:38:36 +0200, > >> Gustavo A. R. Silva wrote: > >>> > >>> Replace "fallthru" with a proper "fall through" annotation. > >>> > >>> This fix is part of the ongoing efforts to enabling > >>> -Wimplicit-fallthrough > >>> > >>> Signed-off-by: Gustavo A. R. Silva > >> > >> Thanks, applied. > > > > BTW, does "fallthru" really cause a warning? I thought it's also > > accepted as well as "fall-through". At least, my gcc-8 doesn't give a > > warning with "fallthru". > > > > You are correct. It does not trigger a warning. > > There are about 50 similar instances in the whole codebase. And, as they > are just a few, what I'm trying to do is to replace them with the most > commonly used form: "fall through" Hm, then I'm not sure whether it's worth for further similar replacements. A term "fallthru" is also very commonly used, and the compiler knows it, too, so why bother to rewrite? I don't mean to revert the already applied changes, but maybe better to concentrate on fixing other real bugs (and/or real warnings). thanks, Takashi