From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E23C28CF6 for ; Wed, 1 Aug 2018 04:50:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 756EE20844 for ; Wed, 1 Aug 2018 04:50:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 756EE20844 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732972AbeHAGeB (ORCPT ); Wed, 1 Aug 2018 02:34:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:49100 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731592AbeHAGeB (ORCPT ); Wed, 1 Aug 2018 02:34:01 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 33296AE02; Wed, 1 Aug 2018 04:50:20 +0000 (UTC) Date: Wed, 01 Aug 2018 06:50:18 +0200 Message-ID: From: Takashi Iwai To: "kbuild test robot" Cc: , , , , , "Rohit kumar" , , , , , , , Subject: Re: [PATCH v4 4/4] ASoC: qcom: add sdm845 sound card support In-Reply-To: <201808011127.1snVqYkN%fengguang.wu@intel.com> References: <1532945454-10437-5-git-send-email-rohitkr@codeaurora.org> <201808011127.1snVqYkN%fengguang.wu@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 01 Aug 2018 05:46:48 +0200, kbuild test robot wrote: > > Hi Rohit, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on asoc/for-next] > [also build test WARNING on next-20180731] > [cannot apply to v4.18-rc7] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Rohit-kumar/Add-support-for-audio-on-SDM845-SoC/20180801-082203 > base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > reproduce: > # apt-get install sparse > make ARCH=x86_64 allmodconfig > make C=1 CF=-D__CHECK_ENDIAN__ > > > sparse warnings: (new ones prefixed by >>) > > >> sound/soc/qcom/sdm845.c:193:27: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int [unsigned] val @@ got restricted snd_unsigned int [unsigned] val @@ > sound/soc/qcom/sdm845.c:193:27: expected unsigned int [unsigned] val > sound/soc/qcom/sdm845.c:193:27: got restricted snd_pcm_format_t [usertype] > > vim +193 sound/soc/qcom/sdm845.c > > 181 > 182 static int sdm845_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd, > 183 struct snd_pcm_hw_params *params) > 184 { > 185 struct snd_interval *rate = hw_param_interval(params, > 186 SNDRV_PCM_HW_PARAM_RATE); > 187 struct snd_interval *channels = hw_param_interval(params, > 188 SNDRV_PCM_HW_PARAM_CHANNELS); > 189 struct snd_mask *fmt = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT); > 190 > 191 rate->min = rate->max = DEFAULT_SAMPLE_RATE_48K; > 192 channels->min = channels->max = 2; > > 193 snd_mask_set(fmt, SNDRV_PCM_FORMAT_S16_LE); FYI, we have introduced a new helper, snd_mask_set_format(), just for avoiding this sparse warning. It's already in Mark's for-next tree. thanks, Takashi