mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "DaeRyong Jeong" <threeearcat@gmail.com>
Cc: "Colin King" <colin.king@canonical.com>, <perex@perex.cz>,
	<alsa-devel@alsa-project.org>, "Kyungtae Kim" <kt0755@gmail.com>,
	"Byoungyoung Lee" <lifeasageek@gmail.com>,
	<syzkaller@googlegroups.com>, <bammanag@purdue.edu>,
	"LKML" <linux-kernel@vger.kernel.org>
Subject: Re: WARNING in port_delete
Date: Tue, 24 Jul 2018 09:00:55 +0200	[thread overview]
Message-ID: <s5hy3e1xgm0.wl-tiwai@suse.de> (raw)
In-Reply-To: <CACsK=jdZ5W8AHtjZinwh=9-e5jUo_Lo1mNesvDygdJhPRpPMvw@mail.gmail.com>

On Tue, 24 Jul 2018 05:59:56 +0200,
DaeRyong Jeong wrote:
> 
> I just realized that the crash has been spotted by Syzkaller a few days before.
> (https://syzkaller.appspot.com/bug?id=3490860a465e6b39227c6906f0ef2d40ad4d5bb1)
> 
> I'm CC'ing Syzkaller's mailing list.

It's very likely a false-positive sanity check, and if so, nothing
serious at all.  We may simply remove two snd_BUG_ON() lines.

But I'd love to have a C reproducer to confirm my understanding is
correct...


thanks,

Takashi

---
--- a/sound/core/seq/seq_ports.c
+++ b/sound/core/seq/seq_ports.c
@@ -272,9 +272,6 @@ static int port_delete(struct snd_seq_client *client,
 	if (port->private_free)
 		port->private_free(port->private_data);
 
-	snd_BUG_ON(port->c_src.count != 0);
-	snd_BUG_ON(port->c_dest.count != 0);
-
 	kfree(port);
 	return 0;
 }

  reply	other threads:[~2018-07-24  7:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24  3:36 Dae R. Jeong
2018-07-24  3:59 ` DaeRyong Jeong
2018-07-24  7:00   ` Takashi Iwai [this message]
     [not found]     ` <3e2c5bd7-daac-4af8-9419-20d775a0b063@Spark>
2018-07-24  7:23       ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2018-07-11 19:55 syzbot
2018-10-06 12:58 ` syzbot
2019-04-01  7:58 ` syzbot
2019-04-01 19:24   ` Paul E. McKenney
2019-04-02 13:12     ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hy3e1xgm0.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=bammanag@purdue.edu \
    --cc=colin.king@canonical.com \
    --cc=kt0755@gmail.com \
    --cc=lifeasageek@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=syzkaller@googlegroups.com \
    --cc=threeearcat@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®