From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78C0BC5CFC0 for ; Mon, 18 Jun 2018 15:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F36D208A5 for ; Mon, 18 Jun 2018 15:40:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F36D208A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934536AbeFRPkv (ORCPT ); Mon, 18 Jun 2018 11:40:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:47825 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932442AbeFRPkt (ORCPT ); Mon, 18 Jun 2018 11:40:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id AFCC9AD73; Mon, 18 Jun 2018 15:40:48 +0000 (UTC) Date: Mon, 18 Jun 2018 17:40:48 +0200 Message-ID: From: Takashi Iwai To: "Stefan Agner" Cc: "Jaroslav Kysela" , , Subject: Re: [PATCH] ALSA: ctxfi: use enum type CT_SUM_CTL where appropriate In-Reply-To: <20180617134652.1638-1-stefan@agner.ch> References: <20180617134652.1638-1-stefan@agner.ch> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 17 Jun 2018 15:46:49 +0200, Stefan Agner wrote: > > Currently a variable of type enum CT_AMIXER_CTL is used for enum > CT_SUM_CTL values. This leads to warnings when using clang: > sound/pci/ctxfi/ctmixer.c:945:32: warning: implicit conversion from enumeration type > 'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL' > [-Wenum-conversion] > for (i = AMIXER_MASTER_F, j = SUM_IN_F; > ~ ^~~~~~~~ > sound/pci/ctxfi/ctmixer.c:975:29: warning: implicit conversion from enumeration type > 'enum CT_SUM_CTL' to different enumeration type 'enum CT_AMIXER_CTL' > [-Wenum-conversion] > for (i = AMIXER_PCM_F, j = SUM_IN_F; i <= AMIXER_PCM_S; i++, j++) { > ~ ^~~~~~~~ > > Introduce enum CT_SUM_CTL k and it instead. > > Signed-off-by: Stefan Agner Applied, thanks. Takashi