From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751529AbdKURJx (ORCPT ); Tue, 21 Nov 2017 12:09:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:39270 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751306AbdKURJZ (ORCPT ); Tue, 21 Nov 2017 12:09:25 -0500 Date: Tue, 21 Nov 2017 18:09:24 +0100 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, arnd@arndb.de, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, vinod.koul@intel.com, broonie@kernel.org, andriy.shevchenko@linux.intel.com, torvalds@linux-foundation.org Subject: Re: [alsa-devel] [RFC PATCH 3/7] ASoC: Intel: document what Kconfig options do In-Reply-To: <20171118000202.22302-4-pierre-louis.bossart@linux.intel.com> References: <20171118000202.22302-1-pierre-louis.bossart@linux.intel.com> <20171118000202.22302-4-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Nov 2017 01:01:58 +0100, Pierre-Louis Bossart wrote: > > Document what the options are supposed to mean, before clean-up in > next patch. > > No functionality change here. > > Signed-off-by: Pierre-Louis Bossart > --- > sound/soc/intel/Kconfig | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig > index 175b2965ca21..136426d60da0 100644 > --- a/sound/soc/intel/Kconfig > +++ b/sound/soc/intel/Kconfig > @@ -15,16 +15,30 @@ if SND_SOC_INTEL_SST_TOPLEVEL > > config SND_SST_IPC > tristate > + help > + This option controls the IPC core for HiFi2 platforms A help section for non-selectable config is fine, per se, but in most cases it's written as a comment. And, if we do add the help text, it's more important to do that for selectable items. Currently the help texts are missing for the platform configs like SND_SOC_INTEL_HASWELL. thanks, Takashi