From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751892AbdHRILA (ORCPT ); Fri, 18 Aug 2017 04:11:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:59264 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751816AbdHRIK4 (ORCPT ); Fri, 18 Aug 2017 04:10:56 -0400 Date: Fri, 18 Aug 2017 10:10:53 +0200 Message-ID: From: Takashi Iwai To: "Stephen Barber" Cc: , "Dylan Reid" , "Bhumika Goyal" , "Con Kolivas" , "Jaroslav Kysela" , Subject: Re: [PATCH] ALSA: usb-audio: don't retry snd_usb_ctl_msg after timeout In-Reply-To: <20170817221746.45403-1-smbarber@chromium.org> References: <20170817221746.45403-1-smbarber@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Aug 2017 00:17:46 +0200, Stephen Barber wrote: > > A few calls to snd_usb_ctl_msg wrap the function in a retry loop. In > the worst case, the timeout for snd_usb_ctl_msg is 5 seconds, which when > retried 10 times (for example, if a device is removed) could cause a > probe to hang for ~50 seconds. > > Example stack trace from 3.14 which triggered a hung task timeout: > Call Trace: > [] ? inet6_set_link_af.part.35+0x12/0x12 > [] schedule+0x6e/0x70 > [] schedule_timeout+0xfc/0x13c > [] ? rcu_read_unlock_sched_notrace+0x17/0x17 > [] __wait_for_common+0x153/0x190 > [] ? __wait_for_common+0x153/0x190 > [] ? wake_up_state+0x12/0x12 > [] wait_for_completion_timeout+0x1d/0x1f > [] usb_start_wait_urb+0x93/0xf1 > [] usb_control_msg+0xe1/0x11d > [] snd_usb_ctl_msg+0x9c/0xf1 [snd_usb_audio] > [] snd_usb_mixer_set_ctl_value+0x124/0xab1 [snd_usb_audio] > [] snd_usb_mixer_set_ctl_value+0x1c3/0xab1 [snd_usb_audio] > [] snd_usb_mixer_set_ctl_value+0x521/0xab1 [snd_usb_audio] > [] snd_usb_mixer_add_control+0x36a/0x1264 [snd_usb_audio] > [] snd_usb_mixer_add_control+0x805/0x1264 [snd_usb_audio] > [] ? usb_free_urb+0x1a/0x1c > [] snd_usb_mixer_add_control+0x11d9/0x1264 [snd_usb_audio] > [] snd_usb_create_mixer+0xbc/0x286 [snd_usb_audio] > [] 0xffffffffc02cac17 > [] usb_probe_interface+0x17c/0x21c > [] driver_probe_device+0xae/0x1fa > [] __device_attach_driver+0x5f/0x66 > [] ? driver_probe_device+0x1fa/0x1fa > [] bus_for_each_drv+0x87/0xaa > [] __device_attach+0x9d/0x101 > [] device_initial_probe+0x13/0x15 > [] bus_probe_device+0x33/0x96 > [] device_add+0x328/0x547 > [] usb_set_configuration+0x624/0x674 > [] generic_probe+0x45/0x77 > [] usb_probe_device+0x2d/0x40 > [] driver_probe_device+0xae/0x1fa > [] __device_attach_driver+0x5f/0x66 > [] ? driver_probe_device+0x1fa/0x1fa > [] bus_for_each_drv+0x87/0xaa > [] __device_attach+0x9d/0x101 > [] device_initial_probe+0x13/0x15 > [] bus_probe_device+0x33/0x96 > [] device_add+0x328/0x547 > [] ? add_device_randomness+0x111/0x130 > [] usb_new_device+0x2a2/0x3c0 > [] hub_thread+0xa3d/0xeed > [] ? __schedule+0x41e/0x5ac > [] ? finish_wait+0x62/0x62 > [] ? usb_reset_device+0x16a/0x16a > [] kthread+0x108/0x110 > [] ? __kthread_parkme+0x67/0x67 > [] ret_from_fork+0x7c/0xb0 > [] ? __kthread_parkme+0x67/0x67 > > Signed-off-by: Stephen Barber Applied, thanks. Takashi