From: Takashi Iwai <tiwai@suse.de>
To: "Colin King" <colin.king@canonical.com>
Cc: <alsa-devel@alsa-project.org>, <trivial@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: au88x0: Add missing \n to end of dev_err message
Date: Fri, 16 Sep 2016 13:14:21 +0200 [thread overview]
Message-ID: <s5hy42snlki.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160916100925.25282-1-colin.king@canonical.com>
On Fri, 16 Sep 2016 12:09:25 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, the dev_err message is missing a \n so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
> ---
> sound/pci/au88x0/au88x0_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/au88x0/au88x0_core.c b/sound/pci/au88x0/au88x0_core.c
> index d3125c1..e1af24f 100644
> --- a/sound/pci/au88x0/au88x0_core.c
> +++ b/sound/pci/au88x0/au88x0_core.c
> @@ -1043,7 +1043,7 @@ static void vortex_fifo_init(vortex_t * vortex)
> for (x = NR_ADB - 1; x >= 0; x--) {
> hwwrite(vortex->mmio, addr, (FIFO_U0 | FIFO_U1));
> if (hwread(vortex->mmio, addr) != (FIFO_U0 | FIFO_U1))
> - dev_err(vortex->card->dev, "bad adb fifo reset!");
> + dev_err(vortex->card->dev, "bad adb fifo reset!\n");
> vortex_fifo_clearadbdata(vortex, x, FIFO_SIZE);
> addr -= 4;
> }
> --
> 2.9.3
>
>
prev parent reply other threads:[~2016-09-16 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 10:09 Colin King
2016-09-16 11:14 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy42snlki.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®