From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754305Ab3HVVVd (ORCPT ); Thu, 22 Aug 2013 17:21:33 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37206 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429Ab3HVVVb (ORCPT ); Thu, 22 Aug 2013 17:21:31 -0400 Date: Thu, 22 Aug 2013 23:23:16 +0200 Message-ID: From: Takashi Iwai To: Stratos Karafotis Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, "linux-kernel@vger.kernel.org >> LKML" Subject: Re: oops during boot with CONFIG_SND_DYNAMIC_MINORS not set In-Reply-To: <52163660.8000700@semaphore.gr> References: <52153451.10601@semaphore.gr> <52163660.8000700@semaphore.gr> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 22 Aug 2013 19:03:44 +0300, Stratos Karafotis wrote: > > On 08/22/2013 10:59 AM, Takashi Iwai wrote: > > At Thu, 22 Aug 2013 00:42:41 +0300, > > Stratos Karafotis wrote: > >> > >> Hi, > >> > >> I get the following oops during boot when build with CONFIG_SND_DYNAMIC_MINORS > >> not set (3.11-rc6). > >> The issue is vanished building the kernel with CONFIG_SND_DYNAMIC_MINORS=y > >> as suggested in printk message. > >> > >> Regards, > >> Stratos > >> > >> > > > > Could you check the patch below? > > Thanks! > > > > > > Takashi > > > > --- > > From: Takashi Iwai > > Subject: [PATCH] ALSA: hda - Fix NULL dereference with CONFIG_SND_DYNAMIC_MINORS=n > > > > Without the dynamic minor assignment, HDMI codec may have less PCM > > instances than the number of pins, which eventually leads to Oops. > > > > Reported-by: Stratos Karafotis > > Cc: > > Signed-off-by: Takashi Iwai > > --- > > sound/pci/hda/patch_hdmi.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c > > index 030ca86..e2cb92b 100644 > > --- a/sound/pci/hda/patch_hdmi.c > > +++ b/sound/pci/hda/patch_hdmi.c > > @@ -1781,6 +1781,9 @@ static int generic_hdmi_build_controls(struct hda_codec *codec) > > struct snd_pcm_chmap *chmap; > > struct snd_kcontrol *kctl; > > int i; > > + > > + if (pin_idx >= codec->num_pcms) > > + break; > > err = snd_pcm_add_chmap_ctls(codec->pcm_info[pin_idx].pcm, > > SNDRV_PCM_STREAM_PLAYBACK, > > NULL, 0, pin_idx, &chmap); > > > > Hi, > > Unfortunately, still the same problem after applying your patch. Bah, it's a wrong one. The patch below should work better. Sorry for inconvenience. Takashi --- From: Takashi Iwai Subject: [PATCH v2] ALSA: hda - Fix NULL dereference with CONFIG_SND_DYNAMIC_MINORS=n Without the dynamic minor assignment, HDMI codec may have less PCM instances than the number of pins, which eventually leads to Oops. Reported-by: Stratos Karafotis Cc: Signed-off-by: Takashi Iwai --- sound/pci/hda/patch_hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 030ca86..9f35862 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c @@ -1781,6 +1781,9 @@ static int generic_hdmi_build_controls(struct hda_codec *codec) struct snd_pcm_chmap *chmap; struct snd_kcontrol *kctl; int i; + + if (!codec->pcm_info[pin_idx].pcm) + break; err = snd_pcm_add_chmap_ctls(codec->pcm_info[pin_idx].pcm, SNDRV_PCM_STREAM_PLAYBACK, NULL, 0, pin_idx, &chmap); -- 1.8.3.4