From: Takashi Iwai <tiwai@suse.de>
To: Alex Deucher <alexander.deucher@amd.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] 3.4-rc* radeon: No DVI-A output after commit e00e8b5e760cb
Date: Wed, 18 Apr 2012 15:19:53 +0200 [thread overview]
Message-ID: <s5hy5pt89dy.wl%tiwai@suse.de> (raw)
In-Reply-To: <s5h4nshdxid.wl%tiwai@suse.de>
At Wed, 18 Apr 2012 14:39:54 +0200,
Takashi Iwai wrote:
>
> Hi,
>
> I noticed that one machine here gives only the blank output with
> 3.4-rc's. The bisection lead me to affecting commit:
>
> commit e00e8b5e760cbbe9067daeae5454d67c44c8d035
> Author: Alex Deucher <alexander.deucher@amd.com>
> Date: Fri Mar 16 12:22:09 2012 -0400
>
> drm/radeon/kms: fix analog load detection on DVI-I connectors
>
> Reverting this commit helped, it goes back to normal.
>
> On this system, the VGA monitor is connected to DVI over a VGA-DVI
> connector (and even VGA-switcher). So, yeah, it's a strange setup.
> But a regression is a regression.
Looking at the commit again, it appears like a simple logic failure.
It should be "&&" instead of "||".
Takashi
next prev parent reply other threads:[~2012-04-18 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 12:39 Takashi Iwai
2012-04-18 13:19 ` Takashi Iwai [this message]
2012-04-18 13:21 ` [PATCH] drm/radeon/kms: fix the regression of DVI connector check Takashi Iwai
2012-04-18 13:38 ` Alex Deucher
2012-04-18 13:36 ` [PATCH] drm/radeon: fix logic inversion in load detect fix alexdeucher
2012-04-18 13:21 ` [REGRESSION] 3.4-rc* radeon: No DVI-A output after commit e00e8b5e760cb Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy5pt89dy.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®