From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751584Ab1GYHiJ (ORCPT ); Mon, 25 Jul 2011 03:38:09 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57645 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542Ab1GYHh7 (ORCPT ); Mon, 25 Jul 2011 03:37:59 -0400 Date: Mon, 25 Jul 2011 09:37:53 +0200 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: Geert Uytterhoeven , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: Build regressions/improvements in v3.0-rc7 (sound/isa/) In-Reply-To: <20110724122624.324d10dc.rdunlap@xenotime.net> References: <1310585610-434-1-git-send-email-geert@linux-m68k.org> <20110724122624.324d10dc.rdunlap@xenotime.net> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 24 Jul 2011 12:26:24 -0700, Randy Dunlap wrote: > > On Wed, 13 Jul 2011 21:33:30 +0200 Geert Uytterhoeven wrote: > > > + src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_disable': => 544 > > + src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_pointer': => 302 > > + src/sound/isa/ad1816a/ad1816a_lib.c: error: implicit declaration of function 'snd_dma_program': => 244 > > + src/sound/isa/es1688/es1688_lib.c: error: implicit declaration of function 'snd_dma_pointer': => 509 > > + src/sound/isa/es1688/es1688_lib.c: error: implicit declaration of function 'snd_dma_program': => 417 > > + src/sound/isa/gus/gus_dma.c: error: implicit declaration of function 'snd_dma_disable': => 177 > > + src/sound/isa/gus/gus_dma.c: error: implicit declaration of function 'snd_dma_program': => 79 > > + src/sound/isa/gus/gus_pcm.c: error: implicit declaration of function 'snd_dma_pointer': => 619 > > + src/sound/isa/gus/gus_pcm.c: error: implicit declaration of function 'snd_dma_program': => 591 > > + src/sound/isa/sb/sb16_main.c: error: implicit declaration of function 'snd_dma_pointer': => 456 > > + src/sound/isa/sb/sb16_main.c: error: implicit declaration of function 'snd_dma_program': => 276 > > + src/sound/isa/sb/sb8_main.c: error: implicit declaration of function 'snd_dma_pointer': => 425 > > + src/sound/isa/sb/sb8_main.c: error: implicit declaration of function 'snd_dma_program': => 172 > > + src/sound/isa/sscape.c: error: implicit declaration of function 'snd_dma_program': => 481 > > + src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_disable': => 1695 > > + src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_pointer': => 1160 > > + src/sound/isa/wss/wss_lib.c: error: implicit declaration of function 'snd_dma_program': => 1025 > > All of these source files do #include , > but these missing/implicit functions are conditional: > > #ifdef CONFIG_ISA_DMA_API > #define DMA_MODE_NO_ENABLE 0x0100 > > void snd_dma_program(unsigned long dma, unsigned long addr, unsigned int size, unsigned short mode); > void snd_dma_disable(unsigned long dma); > unsigned int snd_dma_pointer(unsigned long dma, unsigned int size); > #endif > > so should these drivers all depend on ISA_DMA_API ? Yes, these are ISA sound cards, so they must have CONFIG_ISA and CONFIG_ISA_DMA. Although CONFIG_SND_SB8_DSP, CONFIG_SND_SB16_DSP and CONFIG_SND_WSS_LIB have no direct dependency, but the drivers selecting these are all in "if SND_ISA" in sound/isa/Kconfig. > or should only pieces of each driver depend on ISA_DMA_API ? I wonder which configuration makes it possible. Did you see a similar problem with randconfig? thanks, Takashi