From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756157Ab1F1G6Q (ORCPT ); Tue, 28 Jun 2011 02:58:16 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54968 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756413Ab1F1G5T (ORCPT ); Tue, 28 Jun 2011 02:57:19 -0400 Date: Tue, 28 Jun 2011 08:57:17 +0200 Message-ID: From: Takashi Iwai To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: linux-next: build failure after merge of the final tree (sound tree related) In-Reply-To: <20110628165039.7e1fa073.sfr@canb.auug.org.au> References: <20110628165039.7e1fa073.sfr@canb.auug.org.au> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.7 Emacs/23.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 28 Jun 2011 16:50:39 +1000, Stephen Rothwell wrote: > > Hi all, > > After merging the final tree, today's linux-next build (i386 defconfig) > failed like this: > > sound/pci/hda/patch_via.c:185:28: error: field 'loopback' has incomplete type > sound/pci/hda/patch_via.c:187:22: error: array type has incomplete element type > sound/pci/hda/patch_via.c: In function 'is_aa_path_mute': > sound/pci/hda/patch_via.c:891:39: error: dereferencing pointer to incomplete type > sound/pci/hda/patch_via.c:891:51: error: dereferencing pointer to incomplete type > sound/pci/hda/patch_via.c:892:11: error: dereferencing pointer to incomplete type > sound/pci/hda/patch_via.c: In function 'add_loopback_list': > sound/pci/hda/patch_via.c:2004:29: warning: type defaults to 'int' in type name > sound/pci/hda/patch_via.c:2004:29: warning: type defaults to 'int' in type name > sound/pci/hda/patch_via.c:2004:29: error: negative width in bit-field '' > sound/pci/hda/patch_via.c:2007:6: error: dereferencing pointer to incomplete type > sound/pci/hda/patch_via.c:2008:6: error: dereferencing pointer to incomplete type > sound/pci/hda/patch_via.c:2009:6: error: dereferencing pointer to incomplete type > > Caused by commit ada509ec00e4 ("ALSA: hda - Simplify analog-low-current > mode check for VIA codecs") which removed the CONFIG_SND_HDA_POWER_SAVE > protection of the usage, but not the definition in > sound/pci/hda/hda_local.h. > > I have added the below patch for today: > > From: Stephen Rothwell > Date: Tue, 28 Jun 2011 16:46:09 +1000 > Subject: [PATCH] ALSA: hda - remove SND_HDA_POWER_SAVE protection of struct > hda_loopback_check > > to fix build problems when it is disabled. > > Signed-off-by: Stephen Rothwell Oh, sorry for overlook. Now I applied your fix to sound tree. thanks, Takashi > --- > sound/pci/hda/hda_local.h | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/hda/hda_local.h b/sound/pci/hda/hda_local.h > index b333bf4..88b277e 100644 > --- a/sound/pci/hda/hda_local.h > +++ b/sound/pci/hda/hda_local.h > @@ -565,7 +565,6 @@ int snd_hda_get_bool_hint(struct hda_codec *codec, const char *key) > * power-management > */ > > -#ifdef CONFIG_SND_HDA_POWER_SAVE > void snd_hda_schedule_power_save(struct hda_codec *codec); > > struct hda_amp_list { > @@ -582,7 +581,6 @@ struct hda_loopback_check { > int snd_hda_check_amp_list_power(struct hda_codec *codec, > struct hda_loopback_check *check, > hda_nid_t nid); > -#endif /* CONFIG_SND_HDA_POWER_SAVE */ > > /* > * AMP control callbacks > -- > 1.7.5.4 > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au > http://www.canb.auug.org.au/~sfr/ >