From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753244Ab0JKHfO (ORCPT ); Mon, 11 Oct 2010 03:35:14 -0400 Received: from cantor.suse.de ([195.135.220.2]:40803 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750838Ab0JKHfM (ORCPT ); Mon, 11 Oct 2010 03:35:12 -0400 Date: Mon, 11 Oct 2010 09:35:10 +0200 Message-ID: From: Takashi Iwai To: Dmitry Torokhov Cc: Chase Douglas , linux-input@vger.kernel.org, xorg-devel@lists.x.org, Chris Bagwell , Andy Whitcroft , Henrik Rydberg , linux-kernel@vger.kernel.org, Peter Hutterer , Duncan McGreggor Subject: Re: [PATCH 0/3] Input: synaptics - multitouch and multifinger support In-Reply-To: <20101010210434.GC18455@core.coreip.homeip.net> References: <1286549880-32580-1-git-send-email-chase.douglas@canonical.com> <1286558135.22715.162.camel@mini> <201010081104.01527.dmitry.torokhov@gmail.com> <20101010210434.GC18455@core.coreip.homeip.net> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 10 Oct 2010 14:04:34 -0700, Dmitry Torokhov wrote: > > On Fri, Oct 08, 2010 at 09:31:30PM +0200, Takashi Iwai wrote: > > At Fri, 8 Oct 2010 11:04:01 -0700, > > Dmitry Torokhov wrote: > > > > > > So I do believe we need to have Takashi's SOB at the very least and maybe > > > credit him as the author of the patches. > > > > I sent my original one, so this should suffice, right? > > > > Takashi, > > Generally I think people should not add or remove any SOB lines except > for their own as the work on the patches, so original patches should > retain their original SOBs... In absence of that I'd like to have > explicit confirmations that I can add SOBs statements; otherwise it just > dilutes the value of SOBs significantly. Yeah, in general, sign-offs should be retained. In this particular case, it's also my (well more exactly my employer's) fault, that blocked the submission of the original patch. In anyway, feel free to add my sign-off there since I already posted my own one as a reference. But, I have an open issue with Chase's patch. Maybe it's rather a question to Henrik: Shouldn't all points be reported as ABS_MT_* events? So far, only the second touch-point is reported via ABS_MT_* while the first point is still reported as ABX_[X|Y]. I corrected this in my patch I posted, but I wasn't sure, too. thanks, Takashi