From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757244Ab0DPIAX (ORCPT ); Fri, 16 Apr 2010 04:00:23 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60507 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757039Ab0DPIAV (ORCPT ); Fri, 16 Apr 2010 04:00:21 -0400 Date: Fri, 16 Apr 2010 10:00:20 +0200 Message-ID: From: Takashi Iwai To: Pavel Machek Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] input: Add LED support to Synaptics device In-Reply-To: <20100415191217.GA1495@ucw.cz> References: <1271257823-23566-1-git-send-email-tiwai@suse.de> <1271257823-23566-3-git-send-email-tiwai@suse.de> <20100415191217.GA1495@ucw.cz> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 15 Apr 2010 21:12:18 +0200, Pavel Machek wrote: > > Hi! > > > The new Synaptics devices have an LED on the top-left corner. > > This is controlled via the command 0x0a with parameters 0x88 or 0x10. > > > > The detection of the LED isn't clear yet. It should have been the new > > capability bits that indicate the presence, but on real machines, it > > doesn't fit. So, for the time being, the driver checks the product id > > in the ext capability bits and assumes that LED exists on the known > > devices. > > > > The support of LED is controlled via a normal input event with EV_LED > > bit mask. It supports LED_MUTE bit. X driver can detect the LED > > support by checking these bits. > > Could we use generic LED API for this? Yeah, actually I started implementing with LED ADI at first. But, then it turned out to be that it's much easier to use the existing LED input bits since this LED is really tightly coupled with the synaptics input device. An individual LED device makes hard to find out the corresponding input device. If we assume there is only one synaptics and only one synaptics-LED device, then yes, the situation can be a bit easier, though. > It is not really 'mute' led after all... If the problem is the misuse of LED_MUTE bit, how about adding a new LED bit, e.g. LED_TOUCHPAD? thanks, Takashi