From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757023AbZHZHMZ (ORCPT ); Wed, 26 Aug 2009 03:12:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757010AbZHZHMY (ORCPT ); Wed, 26 Aug 2009 03:12:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45963 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757003AbZHZHMX (ORCPT ); Wed, 26 Aug 2009 03:12:23 -0400 Date: Wed, 26 Aug 2009 09:12:24 +0200 Message-ID: From: Takashi Iwai To: Jiri Slaby Cc: perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] SOUND: atiixp, use uninitialized_var(chip) In-Reply-To: <1251233977-5819-1-git-send-email-jirislaby@gmail.com> References: <1251233977-5819-1-git-send-email-jirislaby@gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 25 Aug 2009 22:59:34 +0200, Jiri Slaby wrote: > > To avoid wrong compiler warnings, use unitialized_var(chip) in > snd_atiixp_probe's from atiixp and atiixp_modem drivers. > > 'chip' is unused when unset due to retval being nonzero. > > Signed-off-by: Jiri Slaby > Cc: Takashi Iwai > Cc: Jaroslav Kysela Thanks for patches. But I'm not sure whether to apply these. In general, uninitialized_var() should be avoided as much as possible, and I don't see these warnings in my build systems with a few different gcc versions. So, it must be seen only in a very small set of gcc versions, I guess. If so, adding this hack is fairly worthless... Takashi > --- > sound/pci/atiixp.c | 2 +- > sound/pci/atiixp_modem.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/pci/atiixp.c b/sound/pci/atiixp.c > index d6752df..436ffea 100644 > --- a/sound/pci/atiixp.c > +++ b/sound/pci/atiixp.c > @@ -1648,7 +1648,7 @@ static int __devinit snd_atiixp_probe(struct pci_dev *pci, > const struct pci_device_id *pci_id) > { > struct snd_card *card; > - struct atiixp *chip; > + struct atiixp *uninitialized_var(chip); > int err; > > err = snd_card_create(index, id, THIS_MODULE, 0, &card); > diff --git a/sound/pci/atiixp_modem.c b/sound/pci/atiixp_modem.c > index e7e147b..b6191f2 100644 > --- a/sound/pci/atiixp_modem.c > +++ b/sound/pci/atiixp_modem.c > @@ -1285,7 +1285,7 @@ static int __devinit snd_atiixp_probe(struct pci_dev *pci, > const struct pci_device_id *pci_id) > { > struct snd_card *card; > - struct atiixp_modem *chip; > + struct atiixp_modem *uninitialized_var(chip); > int err; > > err = snd_card_create(index, id, THIS_MODULE, 0, &card); > -- > 1.6.3.3 >