From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S933682AbZHEHUh@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933682AbZHEHUh (ORCPT <rfc822;w@1wt.eu>);
	Wed, 5 Aug 2009 03:20:37 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933645AbZHEHUf
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 5 Aug 2009 03:20:35 -0400
Received: from cantor2.suse.de ([195.135.220.15]:35455 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933591AbZHEHUf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 5 Aug 2009 03:20:35 -0400
Date: Wed, 05 Aug 2009 09:20:34 +0200
Message-ID: <s5hy6pyd8vx.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Tejun Heo <tj@kernel.org>
Cc: Greg KH <greg@kroah.com>, Al Viro <viro@ftp.linux.org.uk>,
       Linux Kernel <linux-kernel@vger.kernel.org>, cguthrie@mandriva.org
Subject: Re: [PATCH 1/2] chrdev: implement __[un]register_chrdev()
In-Reply-To: <4A793099.1040704@kernel.org>
References: <4A79283E.7030202@kernel.org>
	<s5hzlaed9me.wl%tiwai@suse.de>
	<4A793099.1040704@kernel.org>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3
 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 05 Aug 2009 16:11:21 +0900,
Tejun Heo wrote:
> 
> Takashi Iwai wrote:
> > At Wed, 05 Aug 2009 15:35:42 +0900,
> > Tejun Heo wrote:
> >> [un]register_chrdev() assume minor range 0-255.  This patch adds __
> >> prefixed versions which take @minorbase and @count explicitly.
> >>
> >> Signed-off-by: Tejun Heo <tj@kernel.org>
> >> Cc: Al Viro <viro@zeniv.linux.org.uk>
> >> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> >> ---
> >> Hello,
> >>
> >> These two patches make sound_core grabbing OSS device number optional.
> >> If there's no objection, I think it would be easiest to push this
> >> through Takashi's tree.
> > 
> > I'm fine to take this.
> > 
> > But, I think EXPORT_SYMBOL(__register_chrdev) and
> > EXPORT_SYMBOL(__unregister_chrdev) are missing in this patch.
> 
> The only current users would be sound_core.c which is always compiled
> built-in. 

CONFIG_SOUND is tristate, so it can be a module.
Actually SUSE kernels have it as a module :)

> Adrian would be mighty unhappy about adding EXPORT_SYMBOL()
> there.

How about to replace the old *register_chrdev() with static inline,
instead?


thanks,

Takashi