mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Stas Sergeev <stsp@aknet.ru>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linux kernel <linux-kernel@vger.kernel.org>,
	Vojtech Pavlik <vojtech@suse.cz>,
	Michael Opdenacker <michael-lists@free-electrons.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch][resend2] pcspkr: fix dependancies
Date: Mon, 05 May 2008 13:02:30 +0200	[thread overview]
Message-ID: <s5hy76pc8u1.wl%tiwai@suse.de> (raw)
In-Reply-To: <481E94EE.5080308@aknet.ru>

At Mon, 05 May 2008 09:02:38 +0400,
Stas Sergeev wrote:
> 
> --- a/arch/x86/kernel/Makefile	2008-04-26 13:40:06.000000000 +0400
> +++ b/arch/x86/kernel/Makefile	2008-04-26 18:22:49.000000000 +0400
> @@ -83,7 +83,7 @@
>  obj-$(CONFIG_VMI)		+= vmi_32.o vmiclock_32.o
>  obj-$(CONFIG_PARAVIRT)		+= paravirt.o paravirt_patch_$(BITS).o
>  
> -ifdef CONFIG_INPUT_PCSPKR
> +ifdef CONFIG_PCSPKR_PLATFORM
>  obj-y				+= pcspeaker.o
>  endif

This could be replaced now better with

  obj-$(CONFIG_PCSPKR_PLATFORM) += pcspeaker.o

without if-endif since CONFIG_PCSPKR_PLATFORM is a bool.

> --- a/sound/drivers/Kconfig	2008-04-26 13:40:21.000000000 +0400
> +++ b/sound/drivers/Kconfig	2008-04-26 18:24:59.000000000 +0400
> @@ -5,8 +5,8 @@
>  
>  
>  config SND_PCSP
> -	tristate "Internal PC speaker support"
> -	depends on X86_PC && HIGH_RES_TIMERS
> +	tristate "PC-Speaker support"
> +	depends on PCSPKR_PLATFORM && X86_PC && HIGH_RES_TIMERS
>  	help
>  	  If you don't have a sound card in your computer, you can include a
>  	  driver for the PC speaker which allows it to act like a primitive
> --- a/drivers/input/misc/Kconfig	2008-04-22 20:50:41.000000000 +0400
> +++ b/drivers/input/misc/Kconfig	2008-04-26 18:23:32.000000000 +0400
> @@ -14,7 +14,7 @@
>  
>  config INPUT_PCSPKR
>  	tristate "PC Speaker support"
> -	depends on ALPHA || X86 || MIPS || PPC_PREP || PPC_CHRP || PPC_PSERIES
> +	depends on PCSPKR_PLATFORM
>  	help
>  	  Say Y here if you want the standard PC Speaker to be used for
>  	  bells and whistles.

These two chunks don't apply on 2.6.26-git tree.  Please recreate the
patch.


thanks,

Takashi

  reply	other threads:[~2008-05-05 11:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-04  4:22 [patch][resend] " Stas Sergeev
2008-05-05  3:57 ` Dmitry Torokhov
2008-05-05  4:26   ` Stas Sergeev
2008-05-05  4:35     ` Dmitry Torokhov
2008-05-05  5:02       ` [patch][resend2] " Stas Sergeev
2008-05-05 11:02         ` Takashi Iwai [this message]
2008-05-08 17:50           ` [patch] " Stas Sergeev
2008-05-08 13:58             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hy76pc8u1.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael-lists@free-electrons.com \
    --cc=stsp@aknet.ru \
    --cc=tglx@linutronix.de \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®