From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1758267AbXKNNy5@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758267AbXKNNy5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Nov 2007 08:54:57 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755140AbXKNNyr
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 14 Nov 2007 08:54:47 -0500
Received: from ns1.suse.de ([195.135.220.2]:45323 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753794AbXKNNyq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Nov 2007 08:54:46 -0500
Date: Wed, 14 Nov 2007 11:01:11 +0100
Message-ID: <s5hy7d1du3c.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: perex@suse.cz, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/4] sound/pci: Drop unnecessary continue
In-Reply-To: <Pine.LNX.4.64.0711140915220.26019@ask.diku.dk>
References: <Pine.LNX.4.64.0711140915220.26019@ask.diku.dk>
User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28)
 (fuki) (+CVS-20070806) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 14 Nov 2007 09:15:51 +0100 (CET),
Julia Lawall wrote:
> 
> From: Julia Lawall <julia@diku.dk>
> 
> Continue is not needed at the bottom of a loop.
> 
> The semantic patch implementing this change is as follows:
> 
> @@
> @@
> 
> for (...;...;...) {
>    ...
>    if (...) {
>      ...
> -   continue;
>    }
> }
> 
> Signed-off-by: Julia Lawall <julia@diku.dk>

Applied to ALSA tree.  Thanks.


Takashi

> ---
> 
> diff -u -p -b -B a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
> --- a/sound/pci/intel8x0.c 2007-10-22 11:25:53.000000000 +0200
> +++ b/sound/pci/intel8x0.c 2007-11-13 23:53:44.000000000 +0100
> @@ -2144,7 +2144,6 @@ static int __devinit snd_intel8x0_mixer(
>   				snd_printk(KERN_ERR "Unable to initialize codec #%d\n", i);
>   			if (i == 0)
>   				goto __err;
> -			continue;
>   		}
>   	}
>   	/* tune up the primary codec */
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>