From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F2C8C433F5 for ; Sun, 8 May 2022 09:11:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231826AbiEHJPF (ORCPT ); Sun, 8 May 2022 05:15:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231431AbiEHJPE (ORCPT ); Sun, 8 May 2022 05:15:04 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 930D2213 for ; Sun, 8 May 2022 02:11:14 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 504361F94E; Sun, 8 May 2022 09:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652001073; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2utLszVOX1va5kwC4Bhl/oahyyYjhEmmhysyvWRmi08=; b=kkT7CCy/jg/Zfk+LWkO9m8oycjdgnuDsT+UfJU9Yp0PtuXlMfb5aoJbbQch733UTG+qi0f lYSVc77uv6gflvMXUNnJE5cYTjFsS6fsbzIOftASbPW4VGldQ9Tqfmrhe6q2FAkru07ZIt GXHlmi+WajS4CD7yDUIZ4RNWta++q4k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652001073; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2utLszVOX1va5kwC4Bhl/oahyyYjhEmmhysyvWRmi08=; b=CCmfS9bk3y21RXSbTTZIbzVf7sIoDEaREDL3/wR+CrNhvnMO3hOEV8FYhQ8/mdD+Ip9N0C PGMGjdg6zvjzqvDQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3D15C2C141; Sun, 8 May 2022 09:11:13 +0000 (UTC) Date: Sun, 08 May 2022 11:11:13 +0200 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: hda - fix unused Realtek function when PM is not enabled In-Reply-To: <20220430193318.29024-1-rdunlap@infradead.org> References: <20220430193318.29024-1-rdunlap@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 Apr 2022 21:33:18 +0200, Randy Dunlap wrote: > > When CONFIG_PM is not enabled, alc_shutup() is not needed, > so move it inside the #ifdef CONFIG_PM guard. > Also drop some contiguous #endif / #ifdef CONFIG_PM for simplicity. > > Fixes this build warning: > sound/pci/hda/patch_realtek.c:886:20: warning: unused function 'alc_shutup' > > Fixes: 08c189f2c552 ("ALSA: hda - Use generic parser codes for Realtek driver") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Takashi Iwai > Cc: Jaroslav Kysela > Cc: alsa-devel@alsa-project.org Thanks, applied now. Takashi