From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7E2C433F5 for ; Thu, 14 Apr 2022 08:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240801AbiDNIZR (ORCPT ); Thu, 14 Apr 2022 04:25:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232646AbiDNIZL (ORCPT ); Thu, 14 Apr 2022 04:25:11 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C9B85F250 for ; Thu, 14 Apr 2022 01:22:47 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 2B04D21618; Thu, 14 Apr 2022 08:22:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1649924566; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kf3xjl8BrBTKoBEu0VHViWW2bRtYjZmKOwW94FdVGl4=; b=YG04xhPZFFb6cki2AIm2z59dtlpDfhUKNVmJZtW3TMVbAurFZlh7k/LujsHpphCNYOR+d0 j+9hNXH1GiyjpKs8t3BsCMRdhECCsr59rrOEz4wIXxj/a2Qpx/pDaOybpm3f3pUbFr64SI qJSBcbuH59IlmhRXdkONArlcBtG1kLk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1649924566; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kf3xjl8BrBTKoBEu0VHViWW2bRtYjZmKOwW94FdVGl4=; b=hQ+/dbdyVTyV5bsMi5SqXnDGhNLfy8rUlq/T63z59AN+DRZnTAn5jIziZf77zHq+Y6l+ey RG/kw661SaWR5uCg== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 163CDA3B87; Thu, 14 Apr 2022 08:22:46 +0000 (UTC) Date: Thu, 14 Apr 2022 10:22:46 +0200 Message-ID: From: Takashi Iwai To: Miles Chen Cc: Jaroslav Kysela , Takashi Iwai , Matthias Brugger , , , , , Randy Dunlap Subject: Re: [PATCH -next] sound/oss/dmasound: fix 'dmasound_setup' defined but not used In-Reply-To: <20220414081119.30851-1-miles.chen@mediatek.com> References: <20220414081119.30851-1-miles.chen@mediatek.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Apr 2022 10:11:18 +0200, Miles Chen wrote: > > We observed: 'dmasound_setup' defined but not used error with > COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build. > > __setup() does not work if MODULE is defined. > Fix it by warpping dmasound_setup with #ifndef MODULES. > > Error(s): > sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function] > > Signed-off-by: Miles Chen This must be a side-effect of the recent fix 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m"). Adding Randy to Cc. IMO, a less uglier way would be to add __maybe_unused to that function. But it's a matter of taste. thanks, Takashi > --- > sound/oss/dmasound/dmasound_core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/oss/dmasound/dmasound_core.c b/sound/oss/dmasound/dmasound_core.c > index 9c48f3a9e3d1..a1b3e71beadf 100644 > --- a/sound/oss/dmasound/dmasound_core.c > +++ b/sound/oss/dmasound/dmasound_core.c > @@ -1428,6 +1428,7 @@ void dmasound_deinit(void) > unregister_sound_dsp(sq_unit); > } > > +#ifndef MODULE > static int dmasound_setup(char *str) > { > int ints[6], size; > @@ -1470,6 +1471,7 @@ static int dmasound_setup(char *str) > } > > __setup("dmasound=", dmasound_setup); > +#endif > > /* > * Conversion tables > -- > 2.18.0 >