From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4692AC433EF for ; Fri, 18 Mar 2022 16:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239277AbiCRQj0 (ORCPT ); Fri, 18 Mar 2022 12:39:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239273AbiCRQjW (ORCPT ); Fri, 18 Mar 2022 12:39:22 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E458185453 for ; Fri, 18 Mar 2022 09:38:02 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 0052A1F390; Fri, 18 Mar 2022 16:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1647621481; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X0oByl3Np95W/JGMh2s73YjW2z7Lg1+kE+fc/TLBgoM=; b=Vmzl0ta4HA7NcL68/s0Si24++kFAjg0zt42x4SkSFwC75jctaQcCQZXyRORdrpoCDNoupg l8cnDu/Yapd+I/SMO/vzcZu34gBXp6A0z5fCMFJRqTSAlVqLRxmSCYKKcu/V6pj/RUNXzv y0WJa+cXbW8PBs/CpZthhzPCt1rnDiI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1647621481; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X0oByl3Np95W/JGMh2s73YjW2z7Lg1+kE+fc/TLBgoM=; b=jVU3Z/OhHnlQvqyh6LiOsajgMSol9EzEC+wS8XcjpoGcr6eWB1zrfA07ohDnZiZlOE1MTF Amq52+EUW6z6NCAQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id DEF0BA3B94; Fri, 18 Mar 2022 16:38:00 +0000 (UTC) Date: Fri, 18 Mar 2022 17:38:00 +0100 Message-ID: From: Takashi Iwai To: Vitaly Rodionov Cc: Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH 0/6] Add new HW variants and fix few minor issues In-Reply-To: <20220318155552.24751-1-vitalyr@opensource.cirrus.com> References: <20220318155552.24751-1-vitalyr@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Mar 2022 16:55:46 +0100, Vitaly Rodionov wrote: > > This series adds new HW variants for Dell's Dolphin and Warlock, > and also fixies few very minor issues. > > Stefan Binding (5): > ALSA: hda/cs8409: Fix Warlock using dual mic configuration > ALSA: hda/cs8409: Re-order quirk table into ascending order > ALSA: hda/cs8409: Fix Full Scale Volume setting for all variants > ALSA: hda/cs8409: Support new Warlock MLK Variants > ALSA: hda/cs8409: Disable HSBIAS_SENSE_EN for Cyborg > > Vitaly Rodionov (1): > ALSA: hda/cs8409: Add new Dolphin HW variants The code changes look OK through a quick glance, but those patches lack of the proper patch descriptions completely. For example, the patch 1 says "ALSA: hda/cs8409: Fix Warlock using dual mic configuration" in the subject, and that's all. Fix what for Warlock model? Why the dual mic configuration makes things better, if any? A few other patches have the same problem: it's not clear *why* the changes are done. Please give a bit more description. Also, the patch 4 introduces the code with a wrong indentation, which is corrected in a later patch. That confuses readers, too. Better to fix in the first place. Could you update those and resubmit? thanks, Takashi