From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A82BC433EF for ; Sat, 30 Oct 2021 15:03:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B02A60FC4 for ; Sat, 30 Oct 2021 15:03:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231932AbhJ3PGG (ORCPT ); Sat, 30 Oct 2021 11:06:06 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:48454 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229633AbhJ3PGE (ORCPT ); Sat, 30 Oct 2021 11:06:04 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id C989B21977; Sat, 30 Oct 2021 15:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1635606213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jeKrQfMrtP1PKfsplTJSoCc8Gz1lAcVYp/BdREbDXLA=; b=AX2lAa/4v9SgMDSyKXVsWtbtjE+UPuCqwxrEHEzsGMl4eTmP42ruLr1EfeWXHikkBvP8bP L5of0gNTnz9mqmitUFMSYphqzkySNPsMe3pBBKg5uOqybOqRa+CQyp/rM2iNfxyf/6vH1C zc41TQQ/BinRhwaJ1BF3EOJG0Q0yaVg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1635606213; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jeKrQfMrtP1PKfsplTJSoCc8Gz1lAcVYp/BdREbDXLA=; b=5VyqPwTfoc4Co45uVd4E47QJE7zcyH6CIb2W6qIa9VRsg44gGejK38iU+vqY9KF5AYRkRb Wa9Fa7QGCa44IYCQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id B58A6A3B83; Sat, 30 Oct 2021 15:03:33 +0000 (UTC) Date: Sat, 30 Oct 2021 17:03:33 +0200 Message-ID: From: Takashi Iwai To: Jason Ormes Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HX-Stomp XL USB_ID. In-Reply-To: References: <20211029183105.28503-1-skryking@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 Oct 2021 16:32:36 +0200, Jason Ormes wrote: > > It appears to, it's basically just the HX Stomp that they have added a few > more buttons to.  The USB ID has changed so it doesn't get the fixed rate that > it needs.  After I added it, I've spent several hours recording through it > without any issues.  Even the midi functionality works.   So give such useful information in the patch description and resubmit. At best, align the Subject line to the other patches, i.e. with the prefix "ALSA: usb-audio: .....", and put the maintainer (me) to Cc in addition to alsa-devel ML. thanks, Takashi > > Jason Ormes > > On Sat, Oct 30, 2021, 4:22 AM Takashi Iwai wrote: > > On Fri, 29 Oct 2021 20:31:05 +0200, > Jason Ormes wrote: > > > > Signed-off-by: Jason Ormes > > Could you give a bit more description? > e.g. does the device work fully compatibly? > > thanks, > > Takashi > > > --- > >  sound/usb/format.c | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/sound/usb/format.c b/sound/usb/format.c > > index 50efccbffb8a..e8fc2c350a9f 100644 > > --- a/sound/usb/format.c > > +++ b/sound/usb/format.c > > @@ -414,6 +414,7 @@ static int line6_parse_audio_format_rates_quirk > (struct snd_usb_audio *chip, > >       case USB_ID(0x0e41, 0x4242): /* Line6 Helix Rack */ > >       case USB_ID(0x0e41, 0x4244): /* Line6 Helix LT */ > >       case USB_ID(0x0e41, 0x4246): /* Line6 HX-Stomp */ > > +        case USB_ID(0x0e41, 0x4253): /* Line6 HX-Stomp XL*/ > >       case USB_ID(0x0e41, 0x4247): /* Line6 Pod Go */ > >       case USB_ID(0x0e41, 0x4248): /* Line6 Helix >= fw 2.82 */ > >       case USB_ID(0x0e41, 0x4249): /* Line6 Helix Rack >= fw 2.82 */ > > -- > > 2.25.1 > > > >