From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=boYM=7Q=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1FFF4C433E0
	for <linux-kernel@archiver.kernel.org>; Wed,  3 Jun 2020 11:24:13 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 0433F20679
	for <linux-kernel@archiver.kernel.org>; Wed,  3 Jun 2020 11:24:13 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726109AbgFCLYM (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 3 Jun 2020 07:24:12 -0400
Received: from mx2.suse.de ([195.135.220.15]:38176 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725833AbgFCLYL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 Jun 2020 07:24:11 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx2.suse.de (Postfix) with ESMTP id 4CDD5AD33;
        Wed,  3 Jun 2020 11:24:13 +0000 (UTC)
Date:   Wed, 03 Jun 2020 13:24:08 +0200
Message-ID: <s5hzh9kcrzb.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Steve Lee <steves.lee@maximintegrated.com>
Cc:     <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
        <tiwai@suse.com>, <ckeepax@opensource.cirrus.com>,
        <geert@linux-m68k.org>, <rf@opensource.wolfsonmicro.com>,
        <shumingf@realtek.com>, <srinivas.kandagatla@linaro.org>,
        <krzk@kernel.org>, <dmurphy@ti.com>, <jack.yu@realtek.com>,
        <nuno.sa@analog.com>, <linux-kernel@vger.kernel.org>,
        <alsa-devel@alsa-project.org>, <ryan.lee.maxim@gmail.com>,
        <ryans.lee@maximintegrated.com>, <steves.lee.maxim@gmail.com>
Subject: Re: [PATCH] ASoC: max98390: Fix potential crash during param fw loading
In-Reply-To: <20200603111819.5824-1-steves.lee@maximintegrated.com>
References: <20200603111819.5824-1-steves.lee@maximintegrated.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 03 Jun 2020 13:18:19 +0200,
Steve Lee wrote:
> 
> @@ -847,7 +861,6 @@ static int max98390_probe(struct snd_soc_component *component)
>  
>  	/* Dsm Setting */
>  	regmap_write(max98390->regmap, DSM_VOL_CTRL, 0x94);
> -	regmap_write(max98390->regmap, DSMIG_EN, 0x19);

Is this change intentional?
It wasn't mentioned in the patch description.


thanks,

Takashi