mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	alsa-devel@alsa-project.org,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 0/2] ASoC: hdmi-codec: fix locking issue
Date: Thu, 24 Oct 2019 14:15:07 +0200	[thread overview]
Message-ID: <s5hzhhqwd9w.wl-tiwai@suse.de> (raw)
In-Reply-To: <20191024113444.GF5207@sirena.co.uk>

On Thu, 24 Oct 2019 13:34:44 +0200,
Mark Brown wrote:
> 
> On Wed, Oct 23, 2019 at 07:53:31PM +0200, Jerome Brunet wrote:
> 
> > With the revert, we are back to the bit ops. Even if it works, Mark's
> > original comment on the bit ops still stands I think. This is why I'm
> > proposing patch 2 but I don't really mind if it is applied or not.
> 
> Yeah, it's not *required* but the atomic operations have lots of spiky
> edges so a simpler locking construct would have less chance of running
> into trouble later when someone's updating the code.

If that's the reason, it should be mentioned specifically in the
commit.  That is, it's not about functionality or efficiency but just
about the code readability.


thanks,

Takashi

      reply	other threads:[~2019-10-24 12:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 16:12 Jerome Brunet
2019-10-23 16:12 ` [PATCH 1/2] Revert "ASoC: hdmi-codec: re-introduce mutex locking" Jerome Brunet
2019-10-23 16:37   ` Mark Brown
2019-10-23 18:26     ` Russell King - ARM Linux admin
2019-10-23 18:46       ` Mark Brown
2019-10-23 18:56   ` Applied "ASoC: hdmi-codec: drop mutex locking again" to the asoc tree Mark Brown
2019-10-23 16:12 ` [PATCH 2/2] ASoC: hdmi-codec: re-introduce mutex locking again Jerome Brunet
2019-10-23 16:23 ` [alsa-devel] [PATCH 0/2] ASoC: hdmi-codec: fix locking issue Takashi Iwai
2019-10-23 17:53   ` Jerome Brunet
2019-10-24 11:34     ` Mark Brown
2019-10-24 12:15       ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hzhhqwd9w.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®