From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A36C31E49 for ; Wed, 19 Jun 2019 05:36:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46FB12084A for ; Wed, 19 Jun 2019 05:36:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730297AbfFSFgf (ORCPT ); Wed, 19 Jun 2019 01:36:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:47082 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725854AbfFSFgf (ORCPT ); Wed, 19 Jun 2019 01:36:35 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8FF37ACD8; Wed, 19 Jun 2019 05:36:34 +0000 (UTC) Date: Wed, 19 Jun 2019 07:36:34 +0200 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 2/3] fonts: Use BUILD_BUG_ON() for checking empty font table In-Reply-To: <896583b9-3231-9e31-e51b-c76b889db85b@infradead.org> References: <20190618203425.10723-1-tiwai@suse.de> <20190618203425.10723-3-tiwai@suse.de> <896583b9-3231-9e31-e51b-c76b889db85b@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jun 2019 01:05:58 +0200, Randy Dunlap wrote: > > On 6/18/19 1:34 PM, Takashi Iwai wrote: > > We have a nice macro, and the check of emptiness of the font table can > > be done in a simpler way. > > > > Signed-off-by: Takashi Iwai > > Hi, > > Looks good to me. > Acked-by: Randy Dunlap > > Also, would you mind adding TER16x32 to Documentation/fb/fbcon.rst, here: > (AFAIK that would be appropriate.) > > 1. fbcon=font: > > Select the initial font to use. The value 'name' can be any of the > compiled-in fonts: 10x18, 6x10, 7x14, Acorn8x8, MINI4x6, > PEARL8x8, ProFont6x11, SUN12x22, SUN8x16, VGA8x16, VGA8x8. OK, will submit another patch. thanks, Takashi