From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56320C04AA7 for ; Mon, 13 May 2019 12:42:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 316C1206A3 for ; Mon, 13 May 2019 12:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728992AbfEMMmO (ORCPT ); Mon, 13 May 2019 08:42:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:36480 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728015AbfEMMmN (ORCPT ); Mon, 13 May 2019 08:42:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A67A9AF61; Mon, 13 May 2019 12:42:12 +0000 (UTC) Date: Mon, 13 May 2019 14:42:12 +0200 Message-ID: From: Takashi Iwai To: Amadeusz =?UTF-8?B?U8WCYXdpxYRza2k=?= Cc: , "Jaroslav Kysela" , Subject: Re: [PATCH v2] ALSA: hda: Fix race between creating and refreshing sysfs entries In-Reply-To: <20190513091801.985-1-amadeuszx.slawinski@linux.intel.com> References: <20190513091801.985-1-amadeuszx.slawinski@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 May 2019 11:18:01 +0200, Amadeusz Sławiński wrote: > > hda_widget_sysfs_reinit() can free underlying codec->widgets structure > on which widget_tree_create() operates. Add locking to prevent such > issues from happening. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110382 > Signed-off-by: Amadeusz Sławiński > --- > > Changes since v1: > - Moved mutexes around the callers > - Added comments noting that functions should be called with mutex held Applied, thanks. Takashi