From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=OQFz=KL=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DA710C6778F
	for <linux-kernel@archiver.kernel.org>; Fri, 27 Jul 2018 09:48:34 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 8831320895
	for <linux-kernel@archiver.kernel.org>; Fri, 27 Jul 2018 09:48:34 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8831320895
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2388666AbeG0LJh (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 27 Jul 2018 07:09:37 -0400
Received: from mx2.suse.de ([195.135.220.15]:55498 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1730632AbeG0LJg (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 27 Jul 2018 07:09:36 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay1.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id 3B7BFAF6E;
        Fri, 27 Jul 2018 09:48:30 +0000 (UTC)
Date:   Fri, 27 Jul 2018 11:48:28 +0200
Message-ID: <s5hzhydxb4j.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Jia-Ju Bai" <baijiaju1990@gmail.com>
Cc:     <kai.heng.feng@canonical.com>, <nob77413@gmail.com>,
        <ruslan.bilovol@gmail.com>, <perex@perex.cz>,
        <jussi@sonarnerd.net>, <elfring@users.sourceforge.net>,
        <daniel@zonque.org>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sound: usb: quirks: Replace mdelay() with msleep() and usleep_range()
In-Reply-To: <20180727085528.5802-1-baijiaju1990@gmail.com>
References: <20180727085528.5802-1-baijiaju1990@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 27 Jul 2018 10:55:28 +0200,
Jia-Ju Bai wrote:
> 
> snd_usb_select_mode_quirk(), snd_usb_set_interface_quirk() and 
> snd_usb_ctl_msg_quirk() are never called in atomic context.
> They call mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep() and usleep_range().
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>

Applied, thanks.


Takashi