From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELtsG3Y9eUkrCVuyjnSHkI5ymoMEcay6Fu1OXZiBpJX2UEZSGd0O6BjuN26756QPhCxS0S6B ARC-Seal: i=1; a=rsa-sha256; t=1521445671; cv=none; d=google.com; s=arc-20160816; b=IsvJwCpeBzNMayCrAG8Yev/A0IoQFLpRB3UL46TtH1j+2i8vEwivLZatEnL06FxmoK eQnG699xqHP2/S9/rvGgOxLab/sdaMMnITxqgGQve6P29C+NoByLchg1AX0GwshdQXwI fXekPyOLUotNirarvROHc7a0YSkWMcGazUmdxT+PuQpWf97ZuHzOZZKE1bkCypf5AGA/ RXJ3h29+WshhWcljSUnF7d9GGS1bsZIxRqlCkN18bW7NAoYN+vbc4x49AdMNW0ypjD4n +wYbZuSY1umIT1HM2pq0N5iE5EYDypAEYyfSUW21pLer/3r9at6Q+7Ac1UnlseGwQnSC uzLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:arc-authentication-results; bh=1aMklMmUs5OmBcJc5f+VCG7skD9r9h/IhkhgTOmVhnw=; b=jLEWxqKymBNTrpdh+gioJTML3g07ICVSB7kq/LOUfue6whM48jDFjjCJftPyaMiLpr C9HI1OOk5Nrem+HqJmODokNJsxRDz1AJXF5IEhYpYtKNw6hobhFfvDanOVYHplSjCdiI bSuJ38W9fTjTOY1oPtKposOS0UCsFbe/yZ3RgHZzOwq92lP39YHTPT96pjHI2GNfVksd U2X3smGoLOVYB+bRowZLsM0DzzapS/ASYCVNUr3yaR2dUCc+ExKCaJ2vwkNllhESHtBn PBSZpqkGYRYkEUZDHry+eTcANQ62fShFp0jukw4ybBo1yi0G+HAEvNRcFII8cDPBRnJF EVUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de Authentication-Results: mx.google.com; spf=pass (google.com: domain of tiwai@suse.de designates 195.135.220.15 as permitted sender) smtp.mailfrom=tiwai@suse.de Date: Mon, 19 Mar 2018 08:47:49 +0100 Message-ID: From: Takashi Iwai To: "Greg Kroah-Hartman" Cc: "Kirill Marinushkin" , , "Ruslan Bilovol" , "Mark Brown" , "Thomas Gleixner" , "Felipe Balbi" , "Philippe Ombredanne" , "Jaroslav Kysela" , Subject: Re: [PATCH] ALSA: usb-audio: Fix parsing descriptor of UAC2 processing unit In-Reply-To: <20180319074019.GA30688@kroah.com> References: <20180319061108.24178-1-k.marinushkin@gmail.com> <20180319074019.GA30688@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1595345312154569888?= X-GMAIL-MSGID: =?utf-8?q?1595351416305011397?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, 19 Mar 2018 08:40:19 +0100, Greg Kroah-Hartman wrote: > > On Mon, Mar 19, 2018 at 07:11:08AM +0100, Kirill Marinushkin wrote: > > Currently, the offsets in the UAC2 processing unit descriptor are > > calculated incorrectly. It causes an issue when connecting the device which > > provides such a feature: > > > > ~~~~ > > [84126.724420] usb 1-1.3.1: invalid Processing Unit descriptor (id 18) > > ~~~~ > > > > After this patch is applied, the UAC2 processing unit inits w/o this error. > > > > Fixes: 5e1ddb481776 ("UAPI: (Scripted) Disintegrate include/linux/usb") > > Signed-off-by: Kirill Marinushkin > > Cc: Mark Brown > > Cc: Jaroslav Kysela > > Cc: Takashi Iwai > > Cc: Thomas Gleixner > > Cc: Felipe Balbi > > Cc: Philippe Ombredanne > > Cc: Greg Kroah-Hartman > > Cc: Ruslan Bilovol > > Cc: linux-kernel@vger.kernel.org > > Cc: alsa-devel@alsa-project.org > > --- > > include/uapi/linux/usb/audio.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Cc: stable > perhaps? Yes, it deserves. But I'd need to double-check the UAC2 specification. It's interesting that such a basic thing hasn't hit until now. Maybe just because it's a fairly minor feature. thanks, Takashi