From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932777AbdHVM2P (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 08:28:15 -0400
Received: from mx2.suse.de ([195.135.220.15]:34563 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S932427AbdHVM2O (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 08:28:14 -0400
Date: Tue, 22 Aug 2017 14:28:12 +0200
Message-ID: <s5hziar9483.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Dan Carpenter" <dan.carpenter@oracle.com>
Cc: "SF Markus Elfring" <elfring@users.sourceforge.net>,
        <alsa-devel@alsa-project.org>, "Jaroslav Kysela" <perex@perex.cz>,
        <kernel-janitors@vger.kernel.org>,
        "LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
In-Reply-To: <20170822121625.syvr64kwyh5xjexg@mwanda>
References: <08ee0d6b-788b-2845-6964-e1e55c2d2292@users.sourceforge.net>
        <20170822121625.syvr64kwyh5xjexg@mwanda>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 22 Aug 2017 14:16:25 +0200,
Dan Carpenter wrote:
> 
>   	err = snd_card_register(card);
> > -	if (err < 0) {
> > +	if (err) {
> > +free_card:
> >  		snd_card_free(card);
> >  		return err;
> >  	}
> 
> I thought we agreed, yesterday, to never use this style of error
> handling?

Yeah, this is definitely no-go.

Also, please don't omit the negative value check.


thanks,

Takashi