From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbcLLOad (ORCPT ); Mon, 12 Dec 2016 09:30:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:32891 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752009AbcLLOab (ORCPT ); Mon, 12 Dec 2016 09:30:31 -0500 Date: Mon, 12 Dec 2016 15:30:28 +0100 Message-ID: From: Takashi Iwai To: Dmitry Torokhov Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Takashi Iwai , Marcos Paulo de Souza Subject: Re: [PATCH 0/4] x86: Trust firmware a bit more about presence of 8042 In-Reply-To: <1481317061-31486-1-git-send-email-dmitry.torokhov@gmail.com> References: <1481317061-31486-1-git-send-email-dmitry.torokhov@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Dec 2016 21:57:37 +0100, Dmitry Torokhov wrote: > > Hi, > > Historically we did not trust PNP data regarding keyboard controllers on > X86, but more and more boards get upset with us if they try to tell us that > there is no keyboard controller and we still go and try to poke at where we > think it might be. To work around this issue let's have a bit more faith in > BIOS data, and if [lack] of PNP devices for mouse and keyboard matches whet > firmware (basically ACPI FADT) tells us, let's abort i8042 probe. > > We add a new flag (enum) to x86_platform.legacy structure so we can > distinguish between cases where platform/subarch never has 8042 (such as > MID platform) and cases where firmware says that it is not there, so that > i8042 driver can either abort immediately or go and check for presence of > PNP devices. We also remove x86_platform.i8042_detect() as it is no longer > used (platforms can set value of x86_platform.legacy.i8042 as needed in > quirks). > > If you are OK with arch/x86 changes please apply together with the input > part. I tested and worked fine. For all patches: Tested-by: Takashi Iwai thanks, Takashi