From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759892AbcBYILT (ORCPT ); Thu, 25 Feb 2016 03:11:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:35399 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758167AbcBYILS (ORCPT ); Thu, 25 Feb 2016 03:11:18 -0500 Date: Thu, 25 Feb 2016 09:11:16 +0100 Message-ID: From: Takashi Iwai To: "Kai-Heng Feng" Cc: , "Kai-Heng Feng" , Subject: Re: [PATCH] ALSA: hda - Fixing background noise on Dell Inspiron 3162 In-Reply-To: <1456384778-23181-1-git-send-email-kai.heng.feng@canonical.com> References: <1456384778-23181-1-git-send-email-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Feb 2016 08:19:38 +0100, Kai-Heng Feng wrote: > > After login to the desktop on Dell Inspiron 3162, > there's a very loud background noise comes from the builtin speaker. > The noise does not go away even if the speaker is muted. > > The noise disappears after using the aamix fixup. > > Codec: Realtek ALC3234 > Address: 0 > AFG Function Id: 0x1 (unsol 1) > Vendor Id: 0x10ec0255 > Subsystem Id: 0x10280725 > Revision Id: 0x100002 > No Modem Function Group found > > BugLink: http://bugs.launchpad.net/bugs/1549620 > Signed-off-by: Kai-Heng Feng Applied, thanks. Takashi > --- > sound/pci/hda/patch_realtek.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index efd4980..72fa58d 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -4749,6 +4749,7 @@ enum { > ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE, > ALC293_FIXUP_LENOVO_SPK_NOISE, > ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY, > + ALC255_FIXUP_DELL_SPK_NOISE, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -5368,6 +5369,12 @@ static const struct hda_fixup alc269_fixups[] = { > .type = HDA_FIXUP_FUNC, > .v.func = alc233_fixup_lenovo_line2_mic_hotkey, > }, > + [ALC255_FIXUP_DELL_SPK_NOISE] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc_fixup_disable_aamix, > + .chained = true, > + .chain_id = ALC255_FIXUP_DELL1_MIC_NO_PRESENCE > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { > @@ -5410,6 +5417,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1028, 0x06df, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK), > SND_PCI_QUIRK(0x1028, 0x06e0, "Dell", ALC293_FIXUP_DISABLE_AAMIX_MULTIJACK), > SND_PCI_QUIRK(0x1028, 0x0704, "Dell XPS 13", ALC256_FIXUP_DELL_XPS_13_HEADPHONE_NOISE), > + SND_PCI_QUIRK(0x1028, 0x0725, "Dell Inspiron 3162", ALC255_FIXUP_DELL_SPK_NOISE), > SND_PCI_QUIRK(0x1028, 0x164a, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1028, 0x164b, "Dell", ALC293_FIXUP_DELL1_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2), > -- > 2.5.0 > >