From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751981AbbHBHKX (ORCPT ); Sun, 2 Aug 2015 03:10:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:59144 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519AbbHBHKW (ORCPT ); Sun, 2 Aug 2015 03:10:22 -0400 Date: Sun, 02 Aug 2015 09:10:17 +0200 Message-ID: From: Takashi Iwai To: "Tomer Barletz" Cc: , , , Subject: Re: [PATCH] Fix logical-not-parentheses warning In-Reply-To: <1438494202-30797-1-git-send-email-barletz@gmail.com> References: <1438494202-30797-1-git-send-email-barletz@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 02 Aug 2015 07:43:22 +0200, Tomer Barletz wrote: > > Signed-off-by: Tomer Barletz This is rather a gcc5 problem that doesn't recognize the expression correctly. Though, this change make things worse, so I'm willing to take it. But please give the warning message itself in changelog to show exactly what is the issue. The subject doesn't enough to understand why this change is needed. thanks, Takashi > --- > sound/pci/oxygen/oxygen_mixer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c > index 6492bca..4ca1266 100644 > --- a/sound/pci/oxygen/oxygen_mixer.c > +++ b/sound/pci/oxygen/oxygen_mixer.c > @@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl, > int changed; > > mutex_lock(&chip->mutex); > - changed = !value->value.integer.value[0] != chip->dac_mute; > + changed = (!value->value.integer.value[0]) != chip->dac_mute; > if (changed) { > chip->dac_mute = !value->value.integer.value[0]; > chip->model.update_dac_mute(chip); > -- > 2.4.3 > >