From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370AbbAOHda (ORCPT ); Thu, 15 Jan 2015 02:33:30 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44645 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbbAOHda (ORCPT ); Thu, 15 Jan 2015 02:33:30 -0500 Date: Thu, 15 Jan 2015 08:33:26 +0100 Message-ID: From: Takashi Iwai To: Davidlohr Bueso Cc: Andrew Veliath , Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound/oss: use current->state helpers In-Reply-To: <1421305903.17403.0.camel@stgolabs.net> References: <1421305903.17403.0.camel@stgolabs.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 14 Jan 2015 23:11:43 -0800, Davidlohr Bueso wrote: > > From: Davidlohr Bueso > > Call __set_current_state() instead of assigning the new state directly. > These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping > track of who changed the state. > > Signed-off-by: Davidlohr Bueso The author and sign-off have different addresses. Could you align? thanks, Takashi > --- > sound/oss/msnd_pinnacle.c | 4 ++-- > sound/oss/swarm_cs4297a.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/oss/msnd_pinnacle.c b/sound/oss/msnd_pinnacle.c > index c23f9f9..a8ceef8 100644 > --- a/sound/oss/msnd_pinnacle.c > +++ b/sound/oss/msnd_pinnacle.c > @@ -675,7 +675,7 @@ static void dsp_write_flush(void) > timeout); > clear_bit(F_WRITEFLUSH, &dev.flags); > if (!signal_pending(current)) { > - current->state = TASK_INTERRUPTIBLE; > + __set_current_state(TASK_INTERRUPTIBLE); > schedule_timeout(get_play_delay_jiffies(DAP_BUFF_SIZE)); > } > clear_bit(F_WRITING, &dev.flags); > @@ -1288,7 +1288,7 @@ static int __init calibrate_adc(WORD srate) > & ~0x0001, dev.SMA + SMA_wCurrHostStatusFlags); > if (msnd_send_word(&dev, 0, 0, HDEXAR_CAL_A_TO_D) == 0 && > chk_send_dsp_cmd(&dev, HDEX_AUX_REQ) == 0) { > - current->state = TASK_INTERRUPTIBLE; > + __set_current_state(TASK_INTERRUPTIBLE); > schedule_timeout(HZ / 3); > return 0; > } > diff --git a/sound/oss/swarm_cs4297a.c b/sound/oss/swarm_cs4297a.c > index a33e8ce..213a416 100644 > --- a/sound/oss/swarm_cs4297a.c > +++ b/sound/oss/swarm_cs4297a.c > @@ -1654,7 +1654,7 @@ static int drain_dac(struct cs4297a_state *s, int nonblock) > s->dma_dac.hwptr = s->dma_dac.swptr = hwptr; > spin_unlock_irqrestore(&s->lock, flags); > remove_wait_queue(&s->dma_dac.wait, &wait); > - current->state = TASK_RUNNING; > + __set_current_state(TASK_RUNNING); > return 0; > } > > -- > 2.1.2 > > > >