From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965337AbaKNKxx (ORCPT ); Fri, 14 Nov 2014 05:53:53 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57596 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965194AbaKNKwT (ORCPT ); Fri, 14 Nov 2014 05:52:19 -0500 Date: Fri, 14 Nov 2014 11:52:18 +0100 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] ALSA: ice1712: remove unused variable In-Reply-To: <1415961547-10330-3-git-send-email-sudipm.mukherjee@gmail.com> References: <1415961547-10330-1-git-send-email-sudipm.mukherjee@gmail.com> <1415961547-10330-3-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 14 Nov 2014 16:09:07 +0530, Sudip Mukherjee wrote: > > buf_size was initialized with snd_pcm_lib_buffer_bytes, > but never used. and so it is safe to be deleted. > > Signed-off-by: Sudip Mukherjee Thanks, applied. Takashi > --- > sound/pci/ice1712/ice1712.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c > index 5975334..6525191 100644 > --- a/sound/pci/ice1712/ice1712.c > +++ b/sound/pci/ice1712/ice1712.c > @@ -620,10 +620,9 @@ static int snd_ice1712_playback_ds_prepare(struct snd_pcm_substream *substream) > { > struct snd_ice1712 *ice = snd_pcm_substream_chip(substream); > struct snd_pcm_runtime *runtime = substream->runtime; > - u32 period_size, buf_size, rate, tmp, chn; > + u32 period_size, rate, tmp, chn; > > period_size = snd_pcm_lib_period_bytes(substream) - 1; > - buf_size = snd_pcm_lib_buffer_bytes(substream) - 1; > tmp = 0x0064; > if (snd_pcm_format_width(runtime->format) == 16) > tmp &= ~0x04; > -- > 1.8.1.2 >