From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752815AbaI3Ior (ORCPT ); Tue, 30 Sep 2014 04:44:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53036 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbaI3Ioq (ORCPT ); Tue, 30 Sep 2014 04:44:46 -0400 Date: Tue, 30 Sep 2014 10:44:44 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/6] ALSA: ctxfi: changed void * to struct hw * In-Reply-To: <1411981406-10611-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1411981406-10611-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 29 Sep 2014 14:33:21 +0530, Sudip Mukherjee wrote: > > in the code we have void *hw and while using we are always typecasting > it to (struct hw *). it is better to use void type of pointer when we > store different types of pointer , but in this code we are only having > struct hw. > So changed all the relevant reference of void *hw to struct hw *hw, > without any modification of the existing code logic. > the next patch of the series will remove the typecasting which is > not required now. Thanks, all patches look much better now, so I took them. Takashi