From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753499Ab3KVH30 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 Nov 2013 02:29:26 -0500
Received: from cantor2.suse.de ([195.135.220.15]:55252 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752240Ab3KVH3Y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 Nov 2013 02:29:24 -0500
Date: Fri, 22 Nov 2013 08:29:22 +0100
Message-ID: <s5hzjowhp2l.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Vincent =?UTF-8?B?U3RlaGzDqQ==?= <vincent.stehle@laposte.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-next@vger.kernel.org, Karsten Keil <isdn@linux-pingi.de>
Subject: Re: [PATCH linux-next] hisax: disable build for big-endian arm
In-Reply-To: <1385077794-17022-1-git-send-email-vincent.stehle@laposte.net>
References: <1385077794-17022-1-git-send-email-vincent.stehle@laposte.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Fri, 22 Nov 2013 00:49:54 +0100,
Vincent Stehlé wrote:
> 
> Teles PCI and HFC PCI-bus refuse to build on big-endian ARM; disable them in
> Kconfig.
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Karsten Keil <isdn@linux-pingi.de>
> ---
> 
> Hi,
> 
> This can be seen on e.g. linux next-20131121 with arm allyesconfig.
> 
> Best regards,
> 
> V.
> 
>  drivers/isdn/hisax/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
> index d9edcc9..53dbb75 100644
> --- a/drivers/isdn/hisax/Kconfig
> +++ b/drivers/isdn/hisax/Kconfig
> @@ -109,7 +109,7 @@ config HISAX_16_3
>  
>  config HISAX_TELESPCI
>  	bool "Teles PCI"
> -	depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> +	depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN)))

Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally?

	depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM))

Or maybe just

	depends on PCI && (X86 || BROKEN)

(Alpha?  Can anyone test? :)


Takashi