From: Takashi Iwai <tiwai@suse.de>
To: Borislav Petkov <bp@alien8.de>
Cc: paulmck@linux.vnet.ibm.com, x86-ml <x86@kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: irq 16: nobody cared
Date: Mon, 22 Apr 2013 11:19:07 +0200 [thread overview]
Message-ID: <s5hzjwq53ec.wl%tiwai@suse.de> (raw)
In-Reply-To: <20130422091310.GA4637@pd.tnic>
At Mon, 22 Apr 2013 11:13:10 +0200,
Borislav Petkov wrote:
>
> On Mon, Apr 22, 2013 at 10:32:17AM +0200, Takashi Iwai wrote:
> > Hm, if it's really due to a stray irq, just adding the missing
> > synchronize_irq() like below would help?
> >
> >
> > Takashi
> >
> > ---
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > index 7b213d5..262dbf1 100644
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -2682,6 +2682,8 @@ static void azx_stop_chip(struct azx *chip)
> > /* disable interrupts */
> > azx_int_disable(chip);
> > azx_int_clear(chip);
> > + if (chip->irq >= 0)
> > + synchronize_irq(chip->irq);
>
> Nope, it doesn't help - I see the same splat.
Thanks. Then I have no idea what's missing in the current
azx_suspend() and azx_resume() codes.
Is the PCI device a HD-audio controller for the built-in analog or
a HDMI audio controller coupled with a graphics chip?
I wonder why no MSI is used there. MSI should have been used for most
of controllers except for cases where blacklisted with PCI SSID or
Nvidia / Creative controllers.
Takashi
next prev parent reply other threads:[~2013-04-22 9:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-20 18:53 Borislav Petkov
2013-04-20 23:52 ` Paul E. McKenney
2013-04-21 10:34 ` Borislav Petkov
2013-04-21 16:30 ` Paul E. McKenney
2013-04-21 16:56 ` Borislav Petkov
2013-04-21 18:10 ` Borislav Petkov
2013-04-21 18:56 ` Paul E. McKenney
2013-04-21 19:06 ` Borislav Petkov
2013-04-21 20:34 ` Paul E. McKenney
2013-04-21 20:51 ` Borislav Petkov
2013-04-21 21:42 ` Borislav Petkov
2013-04-21 22:00 ` Paul E. McKenney
2013-04-21 22:12 ` Borislav Petkov
2013-04-22 8:01 ` Ingo Molnar
2013-04-22 9:18 ` Borislav Petkov
2013-04-22 13:16 ` Paul E. McKenney
2013-04-21 18:47 ` Paul E. McKenney
2013-04-22 8:32 ` Takashi Iwai
2013-04-22 9:13 ` Borislav Petkov
2013-04-22 9:19 ` Takashi Iwai [this message]
2013-04-22 10:06 ` Borislav Petkov
2013-04-22 11:33 ` Takashi Iwai
2013-04-22 13:56 ` Borislav Petkov
2013-04-22 12:56 ` Thomas Gleixner
2013-04-22 14:23 ` Borislav Petkov
2013-04-22 14:44 ` Paul E. McKenney
2013-04-22 21:33 ` Borislav Petkov
2013-04-22 22:07 ` Paul E. McKenney
2013-04-23 14:10 ` Thomas Gleixner
2013-04-23 14:34 ` Borislav Petkov
2013-04-23 15:01 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzjwq53ec.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®