From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752102Ab1GYKyh (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jul 2011 06:54:37 -0400
Received: from cantor2.suse.de ([195.135.220.15]:41625 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751470Ab1GYKyb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jul 2011 06:54:31 -0400
Date: Mon, 25 Jul 2011 12:54:29 +0200
Message-ID: <s5hzkk2y6je.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Lionel Debroux <lionel_debroux@yahoo.fr>
Cc: Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, Kees Cook <kees.cook@canonical.com>,
        Emese Revfy <re.emese@gmail.com>, kernel-janitors@vger.kernel.org
Subject: Re: ac97: quiet make W=1 noise by initializing all fields of snd_ac97_codec_id_vendors and snd_ac97_codec_ids.
In-Reply-To: <788178.91280.qm@smtp129.mail.ukl.yahoo.com>
References: <788178.91280.qm@smtp129.mail.ukl.yahoo.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Sun, 24 Jul 2011 11:40:56 +0200,
Lionel Debroux wrote:
> 
> make W=1 bitterly complains about missing initializations in
> snd_ac97_codec_id_vendors and snd_ac97_codec_ids.
> Initialize the last field, to make the output of make W=1 more readable.
> 
> Patch against current Linus tree.

If we change the whole table entries, it'd be better to use C99 style
init, e.g.

#define _CODEC(_id, _mask, _name) \
	.id = _id, .mask = _mask, .name = _name

static const struct ac97_codec_id snd_ac97_codec_id_vendors[] = {
{ _CODEC(0x41445300, 0xffffff00, "Analog Devices"),},
...

static const struct ac97_codec_id snd_ac97_codec_ids[] = {
{ _CODEC(0x41445303, 0xffffffff, "AD1819"), .patch = patch_ad1819 },
...
{ _CODEC(0x53494c20, 0xffffffe0, "Si3036,8"), .patch = mpatch_si3036, \
  .mpatch = mpatch_si3036, .flags = AC97_MODEM_PATCH },
...


thanks,

Takashi