From: Takashi Iwai <tiwai@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Samu Onkalo" <samu.p.onkalo@nokia.com>,
"Éric Piel" <Eric.Piel@tremplin-utc.net>,
"Guenter Roeck" <guenter.roeck@ericsson.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH v2] lis3: Add support for new LIS3DC / HP3DC chip
Date: Thu, 23 Sep 2010 22:08:12 +0200 [thread overview]
Message-ID: <s5hzkv8kytv.wl%tiwai@suse.de> (raw)
In-Reply-To: <20100923124313.7794e8f6.akpm@linux-foundation.org>
At Thu, 23 Sep 2010 12:43:13 -0700,
Andrew Morton wrote:
>
> On Thu, 23 Sep 2010 08:01:31 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
>
> > A new version of LIS3 chip has slight incompatibilities from former
> > versions. This patch adds the minimal support for it.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> > v1->v2
> > Rebased to patch "lis3: Fix Oops with NULL platform data (v2)"
> >
>
> Wait. I did my own rebasing and came up with a different patch, with
> two extra hunks:
>
> @@ -301,8 +311,9 @@ static irqreturn_t lis302dl_interrupt(in
> wake_up_interruptible(&lis3_dev.misc_wait);
> kill_fasync(&lis3_dev.async_queue, SIGIO, POLL_IN);
> out:
> - if (lis3_dev.pdata && lis3_dev.whoami == WAI_8B && lis3_dev.idev &&
> - lis3_dev.idev->input->users)
> + if (lis3_dev.pdata &&
> + (lis3_dev.whoami == WAI_8B || lis3_dev.whoami == WAI_3DC) &&
> + lis3_dev.idev && lis3_dev.idev->input->users)
> return IRQ_WAKE_THREAD;
> return IRQ_HANDLED;
> }
>
> and
>
> @@ -742,7 +762,7 @@ int lis3lv02d_init_device(struct lis3lv0
> * io-apic is not configurable (and generates a warning) but I keep it
> * in case of support for other hardware.
> */
> - if (dev->pdata && dev->whoami == WAI_8B)
> + if (dev->pdata && (dev->whoami == WAI_8B || dev->whoami == WAI_3DC))
> thread_fn = lis302dl_interrupt_thread1_8b;
> else
> thread_fn = NULL;
>
>
> Did you drop those changes deliberately?
IMO, safer to drop these, so far.
For platform-specific, the driver requires the initialization of some
registers, and currently it's only for WAI_8B chips. WAI_3DC has
incompatibilities and cannot use it as is.
thanks,
Takashi
next prev parent reply other threads:[~2010-09-23 20:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 6:01 Takashi Iwai
2010-09-23 14:49 ` Guenter Roeck
2010-09-23 19:43 ` Andrew Morton
2010-09-23 20:08 ` Takashi Iwai [this message]
2010-09-24 13:58 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzkv8kytv.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Eric.Piel@tremplin-utc.net \
--cc=akpm@linux-foundation.org \
--cc=guenter.roeck@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®