From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754454AbZHKMoi (ORCPT ); Tue, 11 Aug 2009 08:44:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754450AbZHKMoh (ORCPT ); Tue, 11 Aug 2009 08:44:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45704 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754430AbZHKMoe (ORCPT ); Tue, 11 Aug 2009 08:44:34 -0400 Date: Tue, 11 Aug 2009 08:17:35 +0200 Message-ID: From: Takashi Iwai To: Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Clemens Ladisch Subject: Re: linux-next: sound tree build warning In-Reply-To: <20090811132258.8e899735.sfr@canb.auug.org.au> References: <20090811132258.8e899735.sfr@canb.auug.org.au> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 11 Aug 2009 13:22:58 +1000, Stephen Rothwell wrote: > > Hi Takashi, > > Today's linux-next build (x86_64 allmodconfig) produced this warning: > > sound/usb/usbaudio.c: In function 'init_substream_urbs': > sound/usb/usbaudio.c:1087: warning: comparison of distinct pointer types lacks a cast > > Introduced by commit 765e8db078e63fdc076fcf6024c15d3b7b955746 ("sound: > usb-audio: do not make URBs longer than sync packet interval"). Thanks, fixed now on sound git tree with the patch below. Takashi --- diff --git a/sound/usb/usbaudio.c b/sound/usb/usbaudio.c index fa3f7a1..5149c58 100644 --- a/sound/usb/usbaudio.c +++ b/sound/usb/usbaudio.c @@ -1084,7 +1084,7 @@ static int init_substream_urbs(struct snd_usb_substream *subs, unsigned int peri urb_packs = 1; urb_packs *= packs_per_ms; if (subs->syncpipe) - urb_packs = min(urb_packs, 1 << subs->syncinterval); + urb_packs = min(urb_packs, 1U << subs->syncinterval); /* decide how many packets to be used */ if (is_playback) {