From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757392AbYENJZ5 (ORCPT ); Wed, 14 May 2008 05:25:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761577AbYENJZr (ORCPT ); Wed, 14 May 2008 05:25:47 -0400 Received: from mail.suse.de ([195.135.220.2]:56456 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753669AbYENJZp (ORCPT ); Wed, 14 May 2008 05:25:45 -0400 Date: Wed, 14 May 2008 11:25:44 +0200 Message-ID: From: Takashi Iwai To: Bjorn Helgaas Cc: Rene Herman , Alan Cox , Glauber Costa , Ingo Molnar , Thomas Gleixner , Pete Clements , Linux Kernel , ALSA devel Subject: Re: 2.6.26-rc1 regression: ISA DMA broken (bisected) In-Reply-To: <200805131718.40138.bjorn.helgaas@hp.com> References: <4823AAF2.7070102@keyaccess.nl> <20080513180107.1a3893f1@core> <4829D0E5.8050905@keyaccess.nl> <200805131718.40138.bjorn.helgaas@hp.com> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 13 May 2008 17:18:39 -0600, Bjorn Helgaas wrote: > > On Tuesday 13 May 2008 11:33:25 am Rene Herman wrote: > > On 13-05-08 19:01, Alan Cox wrote: > > > On Tue, 13 May 2008 10:59:32 -0600, Bjorn Helgaas wrote: > > >> On Friday 09 May 2008 12:06:55 am Takashi Iwai wrote: > > >>> Thanks for catching it. Yeah, the patch looks buggy. We had an > > >>> implicit assumption that dev = NULL for ISA devices that require 24bit > > >>> DMA. > > >> Naive question #1: Why don't we have a struct device for these > > >> ISA devices? PNP builds a struct device with DMA_24BIT_MASK > > >> for ISAPNP devices. > > > > > > Because nobody has done the needed work to get all the old ISA drivers > > > converted. I guess isa_device would actually be a platform_device > > > wrapper ? > > > > No, isa_device is its own thing, on its own isa_bus (*). It has a struct > > device * readily available though... > > > > (*) drivers/base/isa.c, and explanatory changelog at: > > > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=a5117ba7da37deb09df5eb802dace229b3fb1e9f > > Thanks for the nice changelog. > > isa_register_driver() currently doesn't set a DMA mask. Should it? > > I only see about 35 dma_alloc_coherent() calls that pass NULL. I > guess even those would be a fair amount of work to change, and I > suppose there would be more that I missed. There are 5 pci_alloc_consistent() with NULL, too. Takashi