From: Takashi Iwai <tiwai@suse.de>
To: Matthew Wilcox <matthew@wil.cx>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 3/4] sound: Use stringbuf
Date: Wed, 24 Oct 2007 16:50:16 +0200 [thread overview]
Message-ID: <s5hzly8bm8n.wl%tiwai@suse.de> (raw)
In-Reply-To: <20071024160105.GB27248@parisc-linux.org>
At Wed, 24 Oct 2007 10:01:05 -0600,
Matthew Wilcox wrote:
>
> > Any other bugs I missed?
>
> Let me try to find them ... there was this warning fix:
>
> diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c
> index a901cd1..9a64035 100644
> --- a/sound/isa/ad1848/ad1848_lib.c
> +++ b/sound/isa/ad1848/ad1848_lib.c
> @@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip)
> for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD184
> 8_INIT); timeout--)
> udelay(100);
>
> - snd_printdd("(1) timeout = %d\n", timeout);
> + snd_printdd("(1) timeout = %ld\n", timeout);
>
> #ifdef CONFIG_SND_DEBUG
> if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
>
> but I think that's the only one.
OK, thanks. I fixed it on ALSA tree now.
Takashi
next prev parent reply other threads:[~2007-10-24 16:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 21:12 [PATCH 1/4] stringbuf: A string buffer implementation Matthew Wilcox
2007-10-23 21:12 ` [PATCH 2/4] isdn: Use stringbuf Matthew Wilcox
2007-10-23 21:12 ` [PATCH 3/4] sound: " Matthew Wilcox
2007-10-23 21:12 ` [PATCH 4/4] partitions: Fix non-atomic printk Matthew Wilcox
2007-10-24 14:18 ` [PATCH 3/4] sound: Use stringbuf Takashi Iwai
2007-10-24 16:01 ` Matthew Wilcox
2007-10-24 14:50 ` Takashi Iwai [this message]
2007-10-23 22:11 ` [PATCH 1/4] stringbuf: A string buffer implementation Matt Mackall
2007-10-24 1:49 ` Matthew Wilcox
2007-10-24 15:20 ` Matt Mackall
2007-10-24 15:30 ` Matthew Wilcox
2007-10-23 23:43 ` Linus Torvalds
2007-10-24 2:30 ` Matthew Wilcox
2007-10-24 2:45 ` Andrew Morton
2007-10-24 2:19 ` Eric St-Laurent
2007-10-24 2:35 ` Matthew Wilcox
2007-10-24 2:48 ` Eric St-Laurent
2007-10-24 13:21 ` Florian Weimer
2007-10-24 14:02 ` Matthew Wilcox
2007-10-26 12:05 ` Pekka Enberg
2007-10-27 7:31 ` Pavel Machek
2007-10-30 15:26 ` Denys Vlasenko
2007-10-24 19:58 Stringbuf, v2 Matthew Wilcox
2007-10-24 19:59 ` [PATCH 1/4] stringbuf: A string buffer implementation Matthew Wilcox
2007-10-24 19:59 ` [PATCH 2/4] isdn: Use stringbuf Matthew Wilcox
2007-10-24 19:59 ` [PATCH 3/4] sound: " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzly8bm8n.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®