From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932770AbWF2K5w (ORCPT ); Thu, 29 Jun 2006 06:57:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932671AbWF2K5w (ORCPT ); Thu, 29 Jun 2006 06:57:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:18607 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S932770AbWF2K5v (ORCPT ); Thu, 29 Jun 2006 06:57:51 -0400 Date: Thu, 29 Jun 2006 12:57:49 +0200 Message-ID: From: Takashi Iwai To: Adrian Bunk Cc: perex@suse.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [Alsa-devel] [2.6 patch] fix the SND_FM801_TEA575X dependencies In-Reply-To: <20060629094944.GA29056@stusta.de> References: <20060629094944.GA29056@stusta.de> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (+CVS-20060326) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 29 Jun 2006 11:49:44 +0200, Adrian Bunk wrote: > > CONFIG_SND_FM801=y, CONFIG_SND_FM801_TEA575X=m resulted in the following > compile error: > > <-- snip --> > > ... > LD vmlinux > sound/built-in.o: In function `snd_fm801_free': > fm801.c:(.text+0x3c15b): undefined reference to `snd_tea575x_exit' > sound/built-in.o: In function `snd_card_fm801_probe': > fm801.c:(.text+0x3cfde): undefined reference to `snd_tea575x_init' > make: *** [vmlinux] Error 1 > > <-- snip --> > > This patch fixes kernel Bugzilla #6458. > > Signed-off-by: Adrian Bunk Could it be a simplier one like below? Takashi diff -r cd7256009b28 sound/pci/Kconfig --- a/sound/pci/Kconfig Wed Jun 28 16:39:36 2006 +0200 +++ b/sound/pci/Kconfig Thu Jun 29 12:54:08 2006 +0200 @@ -461,16 +461,13 @@ config SND_FM801 will be called snd-fm801. config SND_FM801_TEA575X - tristate "ForteMedia FM801 + TEA5757 tuner" + bool "TEA5757 tuner support on ForteMedia FM801" depends on SND_FM801 select VIDEO_DEV help Say Y here to include support for soundcards based on the ForteMedia FM801 chip with a TEA5757 tuner connected to GPIO1-3 pins (Media Forte SF256-PCS-02). - - To compile this driver as a module, choose M here: the module - will be called snd-fm801-tea575x. config SND_HDA_INTEL tristate "Intel HD Audio" diff -r cd7256009b28 sound/pci/fm801.c --- a/sound/pci/fm801.c Wed Jun 28 16:39:36 2006 +0200 +++ b/sound/pci/fm801.c Thu Jun 29 12:54:08 2006 +0200 @@ -35,7 +35,7 @@ #include -#if (defined(CONFIG_SND_FM801_TEA575X) || defined(CONFIG_SND_FM801_TEA575X_MODULE)) && (defined(CONFIG_VIDEO_DEV) || defined(CONFIG_VIDEO_DEV_MODULE)) +#ifdef CONFIG_SND_FM801_TEA575X #include #define TEA575X_RADIO 1 #endif