From: sashiko-bot@kernel.org
To: catalin.marinas@arm.com, wei.liu@kernel.org,
"Shradha Gupta" <shradhagupta@linux.microsoft.com>,
mhklinux@outlook.com, baoquan.he@linux.dev
Cc: will@kernel.org, broonie@kernel.org, rppt@kernel.org,
linux-hyperv@vger.kernel.org, kexec@lists.infradead.org,
haiyangz@microsoft.com, pasha.tatashin@soleen.com,
tglx@kernel.org, linux-kernel@vger.kernel.org, kees@kernel.org,
kys@microsoft.com, hpa@zytor.com, brads@mainlining.org,
akpm@linux-foundation.org, mark.rutland@arm.com, bp@alien8.de,
namjain@linux.microsoft.com, longli@microsoft.com,
mingo@redhat.com, pratyush@kernel.org, x86@kernel.org,
maz@kernel.org, linux-arch@vger.kernel.org,
dave.hansen@linux.intel.com, decui@microsoft.com, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] Drivers: hv: Run VMBus kexec cleanup from syscore shutdown
Date: Fri, 09 Oct 2026 10:38:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-165245@kernel.org> (raw)
In-Reply-To: <20261009102250.3361076-1-shradhagupta@linux.microsoft.com>
> ARM64 Hyper-V guests do not run the VMBus kexec cleanup before
> secondary CPUs are stopped. Consequently, the old VMBus connection
> and SynIC state remain active when the kexec kernel starts.
>
> Run the VMBus kexec handler from the existing VMBus syscore shutdown
> callback. syscore_shutdown() runs after device shutdown and before
> machine shutdown, while all CPUs needed by the SynIC CPU hotplug
> teardown are still available. Guard the callback with
> kexec_is_in_progress() so normal restart, halt, and poweroff paths are
> unchanged.
>
> Use the same path on x86 and remove the architecture-specific handler
> pointer and the weak setup/remove interfaces. VMBus teardown now
> precedes hv_stimer_global_cleanup() on x86.
>
> The new x86 ordering relies on commit be0cfab740e5 ("clocksource:
> hyper-v: Remove support for stimer interrupts in message mode"), which
> removed the synthetic timer's dependency on VMBus message delivery.
> Older kernels that retain message-mode stimer interrupts must preserve
> the existing x86 ordering and therefore require an ARM64-specific
> backport.
>
> Document the VMBus cleanup path and its position in shutdown ordering.
>
> Fixes: 9bbb888824e3 ("arm64: hyperv: Initialize hypervisor on boot")
> Link: https://lore.kernel.org/all/20260814093133.3191250-1-shradhagupta@linux.microsoft.com/
> Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> Suggested-by: Michael Kelley <mhklinux@outlook.com>
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261009102215.3360863-1-shradhagupta@linux.microsoft.com?part=2
prev parent reply other threads:[~2026-10-09 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 10:22 [PATCH v4 0/2] hyperv: " Shradha Gupta
2026-10-09 10:22 ` [PATCH v4 1/2] kexec: Add helper to report an active kexec reboot Shradha Gupta
2026-10-09 10:28 ` sashiko-bot
2026-10-09 10:22 ` [PATCH v4 2/2] Drivers: hv: Run VMBus kexec cleanup from syscore shutdown Shradha Gupta
2026-10-09 10:38 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-165245@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=baoquan.he@linux.dev \
--cc=bp@alien8.de \
--cc=brads@mainlining.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kees@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=namjain@linux.microsoft.com \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shradhagupta@linux.microsoft.com \
--cc=tglx@kernel.org \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®