mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
Cc: linux-rt-devel@lists.linux.dev, tj@kernel.org,
	hannes@cmpxchg.org, mkoutny@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 31/40] selftests/sched: Test deadline boosts in deadline_bw_test
Date: Fri, 20 Nov 2026 21:08:59 +0000	[thread overview]
Message-ID: <sashiko-outbox-226131@kernel.org> (raw)
In-Reply-To: <e0d14db39ed097c54761a08cb3a1c3e5a57f81ea.1795207233.git.mathieu.desnoyers@efficios.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] selftests/sched: hang in requeue_pi_new_period() error path on
  FUTEX_WAKE
- [Low] selftests/sched: deadlock in deboost_out_asleep_after_refill()
  error path
--

commit 27cfa3f823b3f1e4dfbcad5af492394f2bdb22ea
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

selftests/sched: Test deadline boosts in deadline_bw_test

This commit adds ten test cases to deadline_bw_test covering SCHED_DEADLINE
priority inheritance boosts, deboosts, runtime refills, and lock waiter
ordering.

> diff --git a/tools/testing/selftests/sched/deadline/deadline_bw_test.c b/tools/testing/selftests/sched/deadline/deadline_bw_test.c
> index cf3b49cf2be28..7925623ed1da7 100644
> --- a/tools/testing/selftests/sched/deadline/deadline_bw_test.c
> +++ b/tools/testing/selftests/sched/deadline/deadline_bw_test.c

[ ... ]

> @@ -1939,6 +2066,664 @@ static int deboost_keeps_own_runtime(void)

[ ... ]

> +static void *asleep_donor(void *arg)
> +{
> +	struct timespec ts;
> +	int err;
> +
> +	aslp_donor_tid = gettid_();
> +	err = set_deadline(0, NSEC_PER_MSEC, NSEC_PER_SEC);
> +	sem_post(&aslp_donor_ready);
> +	if (err) {
> +		ksft_print_msg("the donor refused as a deadline task: %s\n", strerror(-err));
> +		sem_post(&aslp_donor_out);
> +		return (void *)1;
> +	}
> +	if (sem_wait_for(&aslp_owner_locked, 5000)) {
> +		ksft_print_msg("the owner did not take the lock\n");
> +		sem_post(&aslp_donor_out);
> +		return (void *)1;
> +	}
> +	clock_gettime(CLOCK_REALTIME, &ts);
> +	ts.tv_nsec += 200 * 1000000L;
> +	ts.tv_sec += ts.tv_nsec / 1000000000L;
> +	ts.tv_nsec %= 1000000000L;
> +	aslp_donor_locking = 1;
> +	err = pthread_mutex_timedlock(&pi_lock, &ts);
> +	sem_post(&aslp_donor_out);
> +	sem_wait_sig(&aslp_read_done);

[ ... ]

> +static int deboost_out_asleep_after_refill(void)
> +{

[ ... ]

> +	if (pthread_create(&d, NULL, asleep_donor, NULL)) {
> +		ksft_print_msg("the donor thread could not start\n");
> +		return KSFT_FAIL;
> +	}
> +	if (sem_wait_for(&aslp_donor_ready, 5000)) {
> +		ksft_print_msg("the donor is not ready\n");
> +		sem_post(&aslp_owner_locked);
> +		join(d);
> +		return KSFT_FAIL;
> +	}
> +	base = total_bw_of(top_cpu(1));	/* with D, without O */
> +	if (pthread_create(&o, NULL, asleep_owner, NULL)) {
> +		ksft_print_msg("the owner thread could not start\n");
> +		sem_post(&aslp_owner_locked);
> +		join(d);
> +		return KSFT_FAIL;
> +	}

[Severity: Low]
Will join(d) hang on these two error paths if aslp_read_done is not
posted?  Posting aslp_owner_locked wakes asleep_donor(), which then takes
pi_lock and blocks in sem_wait_sig(&aslp_read_done).

[ ... ]

> +static void *rq_w(void *arg)
> +{
> +	long ret;
> +
> +	rq_w_tid = gettid_();
> +	ret = syscall(SYS_futex, &rq_cond, FUTEX_WAIT_REQUEUE_PI | FUTEX_PRIVATE_FLAG,
> +		      0, NULL, &rq_pi, 0);
> +	if (ret) {
> +		ksft_print_msg("FUTEX_WAIT_REQUEUE_PI: %s\n", strerror(errno));
> +		return (void *)1;
> +	}
> +	rq_w_rank = rq_order++;
> +	rq_pi_unlock();
> +	if (set_other(0))
> +		ksft_print_msg("W cannot leave SCHED_DEADLINE\n");
> +	return NULL;
> +}

[ ... ]

> +static int requeue_pi_new_period(void)
> +{

[ ... ]

> +out:
> +	rq_pi_unlock();
> +	if (ret != KSFT_PASS) {
> +		/* Let W go if it was not requeued. */
> +		rq_cond = 1;
> +		syscall(SYS_futex, &rq_cond, FUTEX_WAKE | FUTEX_PRIVATE_FLAG,
> +			1, NULL, NULL, 0);
> +	}
> +	if (have_x && pthread_join(x, &x_ret))
> +		ret = KSFT_FAIL;
> +	if (pthread_join(w, &w_ret))
> +		ret = KSFT_FAIL;

[Severity: Low]
Does FUTEX_WAKE wake W when it is sleeping in FUTEX_WAIT_REQUEUE_PI on
rq_cond?  In the kernel, futex_wake() rejects waiters that have
rt_waiter set with -EINVAL without waking them:

kernel/futex/waitwake.c:futex_wake() {
    ...
		if (this->pi_state || this->rt_waiter) {
			ret = -EINVAL;
			break;
		}
    ...
}

If an earlier setup step such as set_deadline() fails before W is
requeued, W stays asleep on rq_cond and pthread_join(w, &w_ret) hangs.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795207232.git.mathieu.desnoyers@efficios.com?part=31

  reply	other threads:[~2026-11-20 21:09 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 20:41 [PATCH v10 00/40] sched/deadline: bandwidth accounting fixes and selftests Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 01/40] sched/deadline: Keep departing bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 02/40] sched/deadline: Rebuild the root domains' accounting from the task list Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 03/40] sched/deadline: Record the root domain holding a task's bandwidth Mathieu Desnoyers
2026-11-20 21:18   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 04/40] sched/deadline: Leave a dying task out of a rebuild of the accounting Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 05/40] selftests/sched: Test SCHED_DEADLINE bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-20 21:12   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 06/40] selftests/sched: Test the root domain rebuild in deadline_bw_test Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 07/40] sched/deadline: Move a task's bandwidth only where room was made Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 08/40] cgroup/cpuset: Wait for an attach before rebuilding the sched domains Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 09/40] sched: Make deadline policy and affinity changes wait for a cpuset attach Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 10/40] cgroup/cpuset: Give back the bandwidth an attach did not move Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 11/40] cgroup/cpuset: Reserve the bandwidth in the root domain a task moves to Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 12/40] selftests/sched: Test cpuset moves in deadline_bw_test Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 13/40] sched/deadline: Make a rebuild count a task in the root domain it runs in Mathieu Desnoyers
2026-11-20 21:11   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 14/40] sched/deadline: Move a task's bandwidth to " Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 15/40] sched/deadline: Keep a task in the root domain that counts its bandwidth Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 16/40] sched/deadline: Keep the last CPU a task has in its root domain Mathieu Desnoyers
2026-11-20 21:19   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 17/40] cgroup/cpuset: Refuse to take a deadline task out of " Mathieu Desnoyers
2026-11-20 21:22   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 18/40] selftests/sched: Test the root domain of a task in deadline_bw_test Mathieu Desnoyers
2026-11-20 20:54   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 19/40] sched/deadline: Count only active CPUs when spreading extra_bw Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 20/40] sched/deadline: Do not truncate a bandwidth to 32 bits in __dl_add/sub() Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 21/40] rtmutex: Continue the chain walk when a waiter's deadline donor changes Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 22/40] rtmutex: Do not stop the chain walk at an owner whose top waiter changed Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 23/40] sched/deadline: Hold a reference on the deadline donor of a boosted task Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 24/40] selftests/sched: Test the rtmutex chain walk in deadline_bw_test Mathieu Desnoyers
2026-11-20 21:06   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 25/40] sched/deadline: Reset the donor's runtime at a deboost in the class Mathieu Desnoyers
2026-11-20 21:26   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 26/40] sched/deadline: Replenish a throttled task boosted while asleep Mathieu Desnoyers
2026-11-20 21:22   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 27/40] sched/deadline: Count the bandwidth a boosted task is given Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 28/40] sched/deadline: Start a period for a task that enters the class blocked Mathieu Desnoyers
2026-11-20 21:21   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 29/40] sched/deadline: Start a period at a deboost out of the class Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 30/40] sched/deadline: Start a period for a task requeued onto an rt_mutex Mathieu Desnoyers
2026-11-20 21:24   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 31/40] selftests/sched: Test deadline boosts in deadline_bw_test Mathieu Desnoyers
2026-11-20 21:08   ` sashiko-bot [this message]
2026-11-20 20:42 ` [PATCH v10 32/40] sched/deadline: Cancel the replenishment timer with the parameters Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 33/40] sched/deadline: Cap the runtime left of a constrained task at dl_runtime Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 34/40] sched/deadline: Check the runtime of a task that comes back runnable Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 35/40] sched/deadline: Check the runtime of a task whose parameters change Mathieu Desnoyers
2026-11-20 21:38   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 36/40] sched/deadline: Reschedule a running task throttled at its enqueue Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 37/40] sched/deadline: Keep the start of the period across a change of dl_deadline Mathieu Desnoyers
2026-11-20 21:21   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 38/40] sched/deadline: Boost an owner that cannot run on its own reservation Mathieu Desnoyers
2026-11-20 21:33   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 39/40] selftests/sched: Test parameter changes in deadline_bw_test Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 40/40] selftests/sched: Share the helpers of the deadline tests Mathieu Desnoyers
2026-11-20 21:15   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226131@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mkoutny@suse.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®