From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Craig Christophel <merlin@transgeek.com>
Cc: linux-kernel@vger.kernel.org, Keith Owens <kaos@ocs.com.au>
Subject: Re: [PATCH] -- filesystems.c::sys_nfsservctl
Date: 13 Feb 2002 22:26:35 +0100 [thread overview]
Message-ID: <shsd6z9dqes.fsf@charged.uio.no> (raw)
In-Reply-To: <20020213205144Z282414-24962+32@thor.valueweb.net>
In-Reply-To: <20020213205144Z282414-24962+32@thor.valueweb.net>
>>>>> " " == Craig Christophel <merlin@transgeek.com> writes:
> Ok guys get ready to flame me....
> The attached patch removes the lock/unlock in this function.
> Now I am 80%
> sure of this one, but would like a word from the kmod
> maintainer about whether request_module needs the BKL or not.
> do_nfsservctl already takes the BKL inside the function so as
> long as request_module is safe this pair can be removed --
> effectively making do_nfsservctl responsible for it's own
> locking scheme.
What would remain to protect 'nfsd_linkage' if you removed the BKL?
Cheers,
Trond
next prev parent reply other threads:[~2002-02-13 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-13 20:51 Craig Christophel
2002-02-13 21:26 ` Trond Myklebust [this message]
2002-02-13 22:46 ` [PATCH] -- filesystems.c::sys_nfsservctl 2.5.5-pre1 Craig Christophel
2002-02-14 0:42 ` [PATCH] -- filesystems.c::sys_nfsservctl Neil Brown
2002-02-15 11:44 ` how to avoid stale NFS filehandles? Matt Bernstein
2002-02-16 5:39 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsd6z9dqes.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=merlin@transgeek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®