From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Patch to pull NFS server address off root_server_path
Date: 06 Mar 2002 21:26:14 +0100 [thread overview]
Message-ID: <shsk7sp4f4p.fsf@charged.uio.no> (raw)
In-Reply-To: <E16iSfH-0007W9-00@wagner.rustcorp.com.au>
In-Reply-To: <E16iSfH-0007W9-00@wagner.rustcorp.com.au>
>>>>> " " == Rusty Russell <rusty@rustcorp.com.au> writes:
> This patch was submitted to the trivial patch daemon. Looks OK
> to me, Trond?
> --- linux.orig/net/ipv4/ipconfig.c Tue Feb 26 07:14:51 2002
> +++ linux/net/ipv4/ipconfig.c Wed Mar 6 14:01:10 2002
> @@ -1197,6 +1197,16 @@
> ic_dev = ic_first_dev->dev;
> }
> +#ifdef CONFIG_ROOT_NFS
> + {
> + extern void __init root_nfs_parse_addr(char *name, u32
> *addr);
> + u32 addr = INADDR_NONE;
> + root_nfs_parse_addr(root_server_path, &addr);
> + if (root_server_addr == INADDR_NONE)
> + root_server_addr = addr;
> + }
> +#endif +
Erm... Is this __init declaration here correct?
Wouldn't it really be better to move root_nfs_parse_addr() into the
ipconfig code? Since, CONFIG_ROOT_NFS depends on CONFIG_IP_PNP being
set, you could also get rid of your #ifdef above...
Cheers,
Trond
next prev parent reply other threads:[~2002-03-06 20:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-06 4:04 Rusty Russell
2002-03-06 20:26 ` Trond Myklebust [this message]
2002-03-15 4:37 Martin Schwenke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsk7sp4f4p.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®