mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Matthias Andree <matthias.andree@stud.uni-dortmund.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.2.19 NFSv3 client breaks fdopen(3)
Date: 27 Apr 2001 13:11:34 +0200	[thread overview]
Message-ID: <shsn192a97d.fsf@charged.uio.no> (raw)
In-Reply-To: <20010426192632.A18492@maggie.dt.e-technik.uni-dortmund.de> <15080.24119.524229.296133@charged.uio.no> <20010427013028.A30741@emma1.emma.line.org>
In-Reply-To: Matthias Andree's message of "Fri, 27 Apr 2001 01:30:28 +0200"

>>>>> " " == Matthias Andree <matthias.andree@stud.uni-dortmund.de> writes:

     > On Thu, 26 Apr 2001, Trond Myklebust wrote:
    >> Please note that if glibc is checking this return value, it
    >> will still screw up if file->f_pos > 0x7fffffff, which can and
    >> does happen against certain servers (particularly IRIX).

     > Do servers have directories that are this large? It'd take
     > quite some files to get a directory itself (not counting its
     > files) exceed 2 GB, wouldn't it?

Check out IRIX. The xfs filesystem uses full 32 or 64 bit unsigned
cookies on all directories whether they are short or long.

Bottom line: you should not confuse directory cookies with offsets.

    >> As I've said before: it is a bug for glibc to be relying on
    >> seekdir if we want to support non-POSIX compliant filesystems
    >> under Linux.

     > There's no seekdir. No telldir. Just a "get ofile current
     > position".

Same difference.

     > Meanwhile, I took a glance at fileops.c and iofdopen.c of the
     > glibc source RPM that SuSE 7.0 uses, there is no seekdir like
     > stuff involved, it's just that when glibc rolls the dice to get
     > a FILE structure filled, it gathers the current file position,
     > since someone might have called read before fdopen. I think
     > that's legitimate.

     > No seekdir. (would be pointless since seekdir does not return a
     > value) Not even telldir. Just plain fdopen. Is a plain fdopen
     > supposed to fail just because some clients don't understand the
     > semantics some server uses; not even considering who's fault it
     > might be? Certainly not.

File position for an NFS directory can take any 32bit or 64bit
unsigned value. This has been the case on Linux since before glibc2
was even a glimmer in Ulrich Drepper's eye.

Cheers,
   Trond

  reply	other threads:[~2001-04-27 11:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-26 17:26 Matthias Andree
2001-04-26 17:43 ` Trond Myklebust
2001-04-26 23:30   ` Matthias Andree
2001-04-27 11:11     ` Trond Myklebust [this message]
2001-04-27 11:02   ` Matthias Andree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=shsn192a97d.fsf@charged.uio.no \
    --to=trond.myklebust@fys.uio.no \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.andree@stud.uni-dortmund.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®