Re: Linux 2.4.19-pre3

[Trond Myklebust <trond.myklebust@fys.uio.no>]

>>>>> " " == Gerd Knorr <kraxel@bytesex.org> writes:

    >> Here goes -pre3, with the new IDE code. It has been stable
    >> enough time in the -ac tree, in my and Alan's opinion.

     > Doesn't boot my machine.  "Intel machine check architecture
     > supported" is the last message printed before it just hangs.

Ditto on my laptop. I've tracked it down to a change in the file
arch/i386/kernel/bluesmoke.c between pre2 and pre3. My guess is that

- Fix off-by-one error in bluesmoke                     (Dave Jones)

is wrong for some reason. Backing out that change using the appended
patch causes pre3 to boot normally.

Cheers,
  Trond

--- linux-2.4.19-up/arch/i386/kernel/bluesmoke.c.orig	Tue Mar 12 14:56:56 2002
+++ linux-2.4.19-up/arch/i386/kernel/bluesmoke.c	Tue Mar 12 18:07:44 2002
@@ -169,7 +169,7 @@
 	if(l&(1<<8))
 		wrmsr(MSR_IA32_MCG_CTL, 0xffffffff, 0xffffffff);
 	banks = l&0xff;
-	for(i=0;i<banks;i++)
+	for(i=1;i<banks;i++)
 	{
 		wrmsr(MSR_IA32_MC0_CTL+4*i, 0xffffffff, 0xffffffff);
 	}