Re: 2.4.2ac8 lost char devices

[tachino Nobuhiro <tachino@open.nm.fujitsu.co.jp>]

Hello, 

At Fri, 02 Mar 2001 00:42:28 -0500,
<rml@ufl.edu> wrote:
> 
> actually, its not just ps/2 mice -- it seems to be something generic to char
> devices. agpgartis failing to register itself, too.
> 
> what changed with char device handling from ac7 to ac8?
> 
> robert love
> rml@ufl.edu
> -

  misc_register() in drivers/char/misc.c seems to have a problem.


 int misc_register(struct miscdevice * misc)
 {      
        static devfs_handle_t devfs_handle;
-               
+       struct miscdevice *c;
+               
        if (misc->next || misc->prev)
                return -EBUSY;
        down(&misc_sem);
+       c = misc_list.next;
+               
+       while ((c != &misc_list) && (c->minor != misc->minor))
+               c = c->next;
+       if (c == &misc_list) {

  This should be  (c != &misc_list)

+               up(&misc_sem);
+               return -EBUSY;
+       }


---
Nobuhiro Tachino
Development Department
Linux Division
Software Group
FUJITSU LIMITED
TEL: +81 559 24 7273
FAX: +81 559 24 6196
E-Mail: tachino@open.nm.fujitsu.co.jp